[TSan][MIPS] XFAIL long jump tests for MIPS64

[slthakur]

Summary

Mark longjmp tests as XFAIL because longjmp assembly for mips is not yet implemented.

[dvyukov]

LGTM

[slthakur]

Hi @dvyukov, @samsonov,

Now there are two more TSan regression test failing on mips:

1. stack_sync_reuse.cc: Stack layout of foobar is not same as barfoo due to differences in generated code. The barfoo is using one extra saved register and thus its layout is different than foobar. Due to this, variable ‘s’ gets a different stack offset and test fails.

2. race_on_mutex.cc: The stack trace for Thread T1 is not as expected. The stack trace we are getting is :

Previous write of size 8 at 0x0120eb8cc0 by thread T1:
    #0 memset /home/kms/sagar/bin/MyLLVM/llvm/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:586 (race_on_mutex.c.tmp+0x0120067764)
    #1 __GI___pthread_mutex_init /build/glibc-6OdOrK/glibc-2.19/nptl/pthread_mutex_init.c:84 (libpthread.so.0+0x000000d5e4)
    #2 Thread1 /home/kms/sagar/compiler-rt/test/tsan/race_on_mutex.c:8:3 (race_on_mutex.c.tmp+0x01200d4ec4)

This happens because memset that is called from pthread_init_mutex is being intercepted by TSan.

Can we have separate expected stack trace for mips and x86 for race_on_mutex.cc ? Or can we mark these tests as XFAIL for mips ?

[dvyukov]

Sure, you can disable these tests on mips. Just explain in comment why they are disabled.

test/tsan/longjmp.cc

 // RUN: %clang_tsan -O1 %s -o %t && %run %t 2>&1 | FileCheck %s
+
+// Longjmp assembly has not been implemented for mips64 yet
+// XFAIL: mips64
+
 #include <stdio.h>
 #include <stdlib.h>
 #include <setjmp.h>
 
 int foo(jmp_buf env) {
   longjmp(env, 42);
 }
 

test/tsan/longjmp2.cc

 // RUN: %clang_tsan -O1 %s -o %t && %run %t 2>&1 | FileCheck %s
+
+// Longjmp assembly has not been implemented for mips64 yet
+// XFAIL: mips64
+
 #include <stdio.h>
 #include <stdlib.h>
 #include <setjmp.h>
 
 int foo(sigjmp_buf env) {
   printf("env=%p\n", env);
   siglongjmp(env, 42);
 }

test/tsan/longjmp3.cc

 // RUN: %clang_tsan -O1 %s -o %t && %deflake %run %t | FileCheck %s
+
+// Longjmp assembly has not been implemented for mips64 yet
+// XFAIL: mips64
+
 #include <pthread.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <setjmp.h>
 
 void bar(jmp_buf env) {
   volatile int x = 42;
   longjmp(env, 42);

test/tsan/longjmp4.cc

 // RUN: %clang_tsan -O1 %s -o %t && %deflake %run %t | FileCheck %s
+
+// Longjmp assembly has not been implemented for mips64 yet
+// XFAIL: mips64
+
 #include <pthread.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <setjmp.h>
 #include <string.h>
 
 void bar(jmp_buf env) {
   volatile int x = 42;

test/tsan/signal_longjmp.cc

 // RUN: %clang_tsan -O1 %s -o %t && %run %t 2>&1 | FileCheck %s
 
 // Test case for longjumping out of signal handler:
 // https://code.google.com/p/thread-sanitizer/issues/detail?id=75
 
+// Longjmp assembly has not been implemented for mips64 yet
+// XFAIL: mips64
+
 #include <setjmp.h>
 #include <signal.h>
 #include <stdlib.h>
 #include <stdio.h>
 #include <sys/mman.h>
 
 sigjmp_buf fault_jmp;
 volatile int fault_expected;