This is an archive of the discontinued LLVM Phabricator instance.

Differential D95254

[NewPM][opt] Make -enable-new-pm default to LLVM_ENABLE_NEW_PASS_MANAGER
ClosedPublic

Authored by aeubanks on Jan 22 2021, 11:30 AM.

Details

Reviewers
ychen
asbirlea
rnk
Commits
rGc37dd3b6d553: [NewPM][opt] Make -enable-new-pm default to LLVM_ENABLE_NEW_PASS_MANAGER
Summary

This is controlled by the ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER CMake flag.

https://lists.llvm.org/pipermail/llvm-dev/2021-January/147993.html

Diff Detail

Event Timeline

aeubanks requested review of this revision.Jan 22 2021, 11:30 AM
aeubanks created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 22 2021, 11:30 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B86330: Diff 318591.Jan 22 2021, 12:24 PM
aeubanks added reviewers: ychen, asbirlea, rnk.Jan 22 2021, 1:49 PM
ychen accepted this revision.Jan 22 2021, 2:03 PM

Thank you for the great work that makes this default. LGTM.

This revision is now accepted and ready to land.Jan 22 2021, 2:03 PM
asbirlea accepted this revision.Jan 22 2021, 5:49 PM

Woohoo!

Closed by commit rGc37dd3b6d553: [NewPM][opt] Make -enable-new-pm default to LLVM_ENABLE_NEW_PASS_MANAGER (authored by aeubanks). · Explain WhyJan 23 2021, 12:48 PM
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rGc37dd3b6d553: [NewPM][opt] Make -enable-new-pm default to LLVM_ENABLE_NEW_PASS_MANAGER.

Revision Contents

PathSize
llvm/
tools/
opt/
6 lines

Diff 318785

llvm/tools/opt/opt.cpp

Show First 20 Lines • Show All 64 Lines • ▼ Show 20 Lines
static codegen::RegisterCodeGenFlags CFG; static codegen::RegisterCodeGenFlags CFG;
// The OptimizationList is automatically populated with registered Passes by the // The OptimizationList is automatically populated with registered Passes by the
// PassNameParser. // PassNameParser.
// //
static cl::list<const PassInfo*, bool, PassNameParser> static cl::list<const PassInfo*, bool, PassNameParser>
PassList(cl::desc("Optimizations available:")); PassList(cl::desc("Optimizations available:"));
static cl::opt<bool> EnableNewPassManager( static cl::opt<bool>
"enable-new-pm", cl::desc("Enable the new pass manager"), cl::init(false)); EnableNewPassManager("enable-new-pm",
cl::desc("Enable the new pass manager"),
cl::init(LLVM_ENABLE_NEW_PASS_MANAGER));
// This flag specifies a textual description of the optimization pass pipeline // This flag specifies a textual description of the optimization pass pipeline
// to run over the module. This flag switches opt to use the new pass manager // to run over the module. This flag switches opt to use the new pass manager
// infrastructure, completely disabling all of the flags specific to the old // infrastructure, completely disabling all of the flags specific to the old
// pass management. // pass management.
static cl::opt<std::string> PassPipeline( static cl::opt<std::string> PassPipeline(
"passes", "passes",
cl::desc("A textual description of the pass pipeline for optimizing"), cl::desc("A textual description of the pass pipeline for optimizing"),
▲ Show 20 Lines • Show All 961 Lines • Show Last 20 Lines