This is an archive of the discontinued LLVM Phabricator instance.

Differential D95233

[flang] Fix typo in error message
ClosedPublic

Authored by PeteSteinfeld on Jan 22 2021, 7:11 AM.

Details

Reviewers
sscalpone
clementval
Commits
rG02e174e8f77f: [flang] Fix typo in error message
Summary

The title says it all.

Diff Detail

Event Timeline

PeteSteinfeld requested review of this revision.Jan 22 2021, 7:11 AM
PeteSteinfeld created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 22 2021, 7:11 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
PeteSteinfeld added a project: Restricted Project.Jan 22 2021, 7:11 AM
Herald added a subscriber: jdoerfert. · View Herald TranscriptJan 22 2021, 7:11 AM
clementval accepted this revision.Jan 22 2021, 7:20 AM
This revision is now accepted and ready to land.Jan 22 2021, 7:20 AM
This revision was landed with ongoing or failed builds.Jan 22 2021, 7:31 AM
Closed by commit rG02e174e8f77f: [flang] Fix typo in error message (authored by PeteSteinfeld). · Explain Why
This revision was automatically updated to reflect the committed changes.
PeteSteinfeld added a commit: rG02e174e8f77f: [flang] Fix typo in error message.
Harbormaster completed remote builds in B86280: Diff 318514.Jan 22 2021, 7:40 AM

Revision Contents

PathSize
flang/
lib/
Semantics/
2 lines
test/
Semantics/
6 lines

Diff 318522

flang/lib/Semantics/check-call.cpp

Show First 20 Lines • Show All 542 Lines • ▼ Show 20 Lines if (auto argChars{characteristics::DummyArgument::FromActual(
messages.Say( messages.Say(
"Actual procedure argument has interface incompatible with %s"_err_en_US, "Actual procedure argument has interface incompatible with %s"_err_en_US,
dummyName); dummyName);
return; return;
} else { } else {
messages.Say( messages.Say(
"Actual procedure argument has an implicit interface " "Actual procedure argument has an implicit interface "
"which is not known to be compatible with %s which has an " "which is not known to be compatible with %s which has an "
"explcit interface"_err_en_US, "explicit interface"_err_en_US,
dummyName); dummyName);
return; return;
} }
} }
} else { // 15.5.2.9(2,3) } else { // 15.5.2.9(2,3)
if (interface.IsSubroutine() && argInterface.IsFunction()) { if (interface.IsSubroutine() && argInterface.IsFunction()) {
messages.Say( messages.Say(
"Actual argument associated with procedure %s is a function but must be a subroutine"_err_en_US, "Actual argument associated with procedure %s is a function but must be a subroutine"_err_en_US,
▲ Show 20 Lines • Show All 235 Lines • Show Last 20 Lines

flang/test/Semantics/call09.f90

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Lines subroutine test1 ! 15.5.2.9(5)
call s01(null(p)) ! ok call s01(null(p)) ! ok
!ERROR: Actual procedure argument has interface incompatible with dummy argument 'p=' !ERROR: Actual procedure argument has interface incompatible with dummy argument 'p='
call s01(null(ip)) call s01(null(ip))
call s01(sin) ! ok call s01(sin) ! ok
!ERROR: Actual argument associated with procedure dummy argument 'p=' is not a procedure !ERROR: Actual argument associated with procedure dummy argument 'p=' is not a procedure
call s01(null(intPtr)) call s01(null(intPtr))
!ERROR: Actual argument associated with procedure dummy argument 'p=' is not a procedure !ERROR: Actual argument associated with procedure dummy argument 'p=' is not a procedure
call s01(B"0101") call s01(B"0101")
!ERROR: Actual procedure argument has an implicit interface which is not known to be compatible with dummy argument 'p=' which has an explcit interface !ERROR: Actual procedure argument has an implicit interface which is not known to be compatible with dummy argument 'p=' which has an explicit interface
call s01(extfunc) call s01(extfunc)
!ERROR: Actual argument associated with procedure pointer dummy argument 'p=' must be a POINTER unless INTENT(IN) !ERROR: Actual argument associated with procedure pointer dummy argument 'p=' must be a POINTER unless INTENT(IN)
call s02(realfunc) call s02(realfunc)
call s02(p) ! ok call s02(p) ! ok
!ERROR: Actual procedure argument has interface incompatible with dummy argument 'p=' !ERROR: Actual procedure argument has interface incompatible with dummy argument 'p='
call s02(ip) call s02(ip)
!ERROR: Actual argument associated with procedure pointer dummy argument 'p=' must be a POINTER unless INTENT(IN) !ERROR: Actual argument associated with procedure pointer dummy argument 'p=' must be a POINTER unless INTENT(IN)
call s02(procptr()) call s02(procptr())
!ERROR: Actual argument associated with procedure pointer dummy argument 'p=' must be a POINTER unless INTENT(IN) !ERROR: Actual argument associated with procedure pointer dummy argument 'p=' must be a POINTER unless INTENT(IN)
call s02(null()) call s02(null())
!ERROR: Actual argument associated with procedure pointer dummy argument 'p=' must be a POINTER unless INTENT(IN) !ERROR: Actual argument associated with procedure pointer dummy argument 'p=' must be a POINTER unless INTENT(IN)
call s02(null(p)) call s02(null(p))
!ERROR: Actual argument associated with procedure pointer dummy argument 'p=' must be a POINTER unless INTENT(IN) !ERROR: Actual argument associated with procedure pointer dummy argument 'p=' must be a POINTER unless INTENT(IN)
call s02(sin) call s02(sin)
!ERROR: Actual procedure argument has an implicit interface which is not known to be compatible with dummy argument 'p=' which has an explcit interface !ERROR: Actual procedure argument has an implicit interface which is not known to be compatible with dummy argument 'p=' which has an explicit interface
call s02(extfunc) call s02(extfunc)
!ERROR: Actual procedure argument has an implicit interface which is not known to be compatible with dummy argument 'p=' which has an explcit interface !ERROR: Actual procedure argument has an implicit interface which is not known to be compatible with dummy argument 'p=' which has an explicit interface
call s03(extfuncPtr) call s03(extfuncPtr)
end subroutine end subroutine
subroutine callsub(s) subroutine callsub(s)
call s call s
end subroutine end subroutine
subroutine takesrealfunc1(f) subroutine takesrealfunc1(f)
external f external f
▲ Show 20 Lines • Show All 83 Lines • Show Last 20 Lines