This is an archive of the discontinued LLVM Phabricator instance.

Differential D95213

[lld-macho] Ignore -lto_library
ClosedPublic

Authored by int3 on Jan 22 2021, 1:17 AM.

Details

Reviewers
smeenai
Group Reviewers
Restricted Project
Commits
rG041f3ee664c9: [lld-macho] Ignore -lto_library
Summary

Just getting rid of some logspew as I test LLD under existing build
systems.

Diff Detail

Event Timeline

int3 created this revision.Jan 22 2021, 1:17 AM
Herald added subscribers: dang, inglorion. · View Herald TranscriptJan 22 2021, 1:17 AM
int3 requested review of this revision.Jan 22 2021, 1:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 22 2021, 1:17 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B86246: Diff 318454.Jan 22 2021, 1:49 AM
smeenai accepted this revision.Jan 22 2021, 7:54 AM
smeenai added a subscriber: smeenai.

LGTM

lld/MachO/Options.td
865

Should this say "Ignore" instead of (or in addition to) "Deprecated"?

This revision is now accepted and ready to land.Jan 22 2021, 7:54 AM
int3 marked an inline comment as done.Jan 22 2021, 8:35 AM
int3 updated this revision to Diff 318535.Jan 22 2021, 8:36 AM

add 'ignored'

Harbormaster completed remote builds in B86295: Diff 318535.Jan 22 2021, 9:28 AM
Closed by commit rG041f3ee664c9: [lld-macho] Ignore -lto_library (authored by int3). · Explain WhyJan 22 2021, 1:49 PM
This revision was automatically updated to reflect the committed changes.
int3 added a commit: rG041f3ee664c9: [lld-macho] Ignore -lto_library.

Revision Contents

PathSize
lld/
MachO/
3 lines
test/
MachO/
1 line

Diff 318643

lld/MachO/Options.td

Show First 20 Lines • Show All 856 Lines • ▼ Show 20 Linesdef no_objc_category_merging : Flag<["-"], "no_objc_category_merging">,
Flags<[HelpHidden]>, Flags<[HelpHidden]>,
Group<grp_rare>; Group<grp_rare>;
def object_path_lto : Separate<["-"], "object_path_lto">, def object_path_lto : Separate<["-"], "object_path_lto">,
MetaVarName<"<path>">, MetaVarName<"<path>">,
HelpText<"Retain any temporary mach-o file in <path> that would otherwise be deleted during LTO">, HelpText<"Retain any temporary mach-o file in <path> that would otherwise be deleted during LTO">,
Group<grp_rare>; Group<grp_rare>;
def lto_library : Separate<["-"], "lto_library">, def lto_library : Separate<["-"], "lto_library">,
MetaVarName<"<path>">, MetaVarName<"<path>">,
HelpText<"Override the default ../lib/libLTO.dylib as <path>">, HelpText<"Deprecated & ignored. LLD supports LTO directly, without using an external dylib.">,
smeenaiUnsubmitted
Done
ReplyInline Actions

Should this say "Ignore" instead of (or in addition to) "Deprecated"?

smeenai: Should this say "Ignore" instead of (or in addition to) "Deprecated"?
Flags<[HelpHidden]>,
Group<grp_rare>; Group<grp_rare>;
def cache_path_lto : Separate<["-"], "cache_path_lto">, def cache_path_lto : Separate<["-"], "cache_path_lto">,
MetaVarName<"<path>">, MetaVarName<"<path>">,
HelpText<"Use <path> as a directory for the incremental LTO cache">, HelpText<"Use <path> as a directory for the incremental LTO cache">,
Flags<[HelpHidden]>, Flags<[HelpHidden]>,
Group<grp_rare>; Group<grp_rare>;
def prune_interval_lto : Separate<["-"], "prune_interval_lto">, def prune_interval_lto : Separate<["-"], "prune_interval_lto">,
MetaVarName<"<seconds>">, MetaVarName<"<seconds>">,
▲ Show 20 Lines • Show All 430 Lines • Show Last 20 Lines

lld/test/MachO/silent-ignore.test

RUN: %lld -v \ RUN: %lld -v \
RUN: -dynamic \ RUN: -dynamic \
RUN: -no_deduplicate \ RUN: -no_deduplicate \
RUN: -lto_library /lib/foo \ RUN: -lto_library /lib/foo \
RUN: -macosx_version_min 0 \ RUN: -macosx_version_min 0 \
RUN: -dependency_info /path/to/dependency_info.dat \ RUN: -dependency_info /path/to/dependency_info.dat \
RUN: -lto_library ../lib/libLTO.dylib \
RUN: -mllvm -time-passes \ RUN: -mllvm -time-passes \
RUN: -objc_abi_version 2 \ RUN: -objc_abi_version 2 \
RUN: -ios_simulator_version_min 9.0.0 \ RUN: -ios_simulator_version_min 9.0.0 \
RUN: -sdk_version 13.2 RUN: -sdk_version 13.2
RUN: not %lld -v --not-an-ignored-argument 2>&1 | FileCheck %s RUN: not %lld -v --not-an-ignored-argument 2>&1 | FileCheck %s
CHECK: error: unknown argument '--not-an-ignored-argument' CHECK: error: unknown argument '--not-an-ignored-argument'