This is an archive of the discontinued LLVM Phabricator instance.

[lldb/Commands] Refactor ProcessLaunchCommandOptions to use TableGen (NFC)
ClosedPublic

Authored by mib on Jan 20 2021, 9:39 AM.

Details

Summary

This patch refactors the current implementation of
ProcessLaunchCommandOptions to be generated by TableGen.

The patch also renames the class to CommandOptionsProcessLaunch to
align better with the rest of the codebase style and moves it to
separate files.

Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>

Diff Detail

Event Timeline

mib created this revision.Jan 20 2021, 9:39 AM
mib requested review of this revision.Jan 20 2021, 9:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2021, 9:39 AM
mib updated this revision to Diff 317911.Jan 20 2021, 9:50 AM

Add header guards and split tablegen long description into multiple lines.

This revision is now accepted and ready to land.Jan 20 2021, 9:52 AM
mib updated this revision to Diff 317914.Jan 20 2021, 9:54 AM
Harbormaster completed remote builds in B85915: Diff 317914.
JDevlieghere added inline comments.Jan 20 2021, 1:17 PM
lldb/source/Commands/CommandOptionsProcessLaunch.h
1

Nit: header files should have the -------------*- C++ -*-===// at the end.