This is an archive of the discontinued LLVM Phabricator instance.

[libomptarget][devicertl] Wrap source in declare target pragmas
ClosedPublic

Authored by JonChesterfield on Jan 20 2021, 7:19 AM.

Details

Summary

[libomptarget][devicertl] Wrap source in declare target pragmas

Factored out of D93135 / D94745. C++ and cuda ignore unknown pragmas
so this is a NFC for the current implementation language. Removes noise
from patches for building deviceRTL as openmp.

Diff Detail

Event Timeline

JonChesterfield requested review of this revision.Jan 20 2021, 7:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2021, 7:19 AM
tianshilei1992 accepted this revision.Jan 20 2021, 7:23 AM
tianshilei1992 added inline comments.
openmp/libomptarget/deviceRTLs/amdgcn/src/amdgcn_locks.hip
30

One nit. There is a blank line between declare target and the include, so I’d also insert a blank line between the last line of code and the end declare target.

This revision is now accepted and ready to land.Jan 20 2021, 7:23 AM
  • insert whitespace requested at review
openmp/libomptarget/deviceRTLs/amdgcn/src/amdgcn_locks.hip
30

Sure, may as well.

This revision was landed with ongoing or failed builds.Jan 20 2021, 7:51 AM
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B85888: Diff 317871.