Page MenuHomePhabricator
Differential D95027

[mlir] fix the rocm runtime wrapper to account for cuda / rocm api differences
ClosedPublic
Actions

Authored by gysit on Jan 20 2021, 1:05 AM.

Details

Reviewers
csigg
Commits
rG4c1eaf26ae70: [mlir] fix the rocm runtime wrapper to account for cuda / rocm api differences
Summary

The patch adapts the rocm runtime wrapper due to subtle differences between the cuda and the rocm/hip runtime api.

Diff Detail

Event Timeline

gysit created this revision.Jan 20 2021, 1:05 AM
Herald added subscribers: teijeong, rdzhabarov, tatianashp and 15 others. · View Herald TranscriptJan 20 2021, 1:05 AM
gysit requested review of this revision.Jan 20 2021, 1:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2021, 1:05 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B85850: Diff 317799.Jan 20 2021, 1:57 AM
csigg accepted this revision.Jan 20 2021, 2:33 AM

Thanks for the fix!

This revision is now accepted and ready to land.Jan 20 2021, 2:33 AM
Closed by commit rG4c1eaf26ae70: [mlir] fix the rocm runtime wrapper to account for cuda / rocm api differences (authored by gysit). · Explain WhyJan 20 2021, 9:49 AM
This revision was automatically updated to reflect the committed changes.
gysit added a commit: rG4c1eaf26ae70: [mlir] fix the rocm runtime wrapper to account for cuda / rocm api differences.

Revision Contents
Changeset List

PathSize
mlir/
tools/
mlir-rocm-runner/
9 lines

Diff 317910

View Options

mlir/tools/mlir-rocm-runner/rocm-runtime-wrappers.cpp

Loading...