Paths

Table of Contentst

Differential D95006

[libc][NFC] add "LlvmLibc" as a prefix to all test names
ClosedPublic
Actions

Authored by michaelrj on Jan 19 2021, 3:19 PM.

Tags

Subscribers

Details

Reviewers

Summary

Having a consistent prefix makes selecting all of the llvm libc tests
easier on any platform that is also using the gtest framework.
This also modifies the TEST and TEST_F macros to enforce this change
moving forward.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

michaelrj created this revision.Jan 19 2021, 3:19 PM

Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald TranscriptJan 19 2021, 3:19 PM

michaelrj requested review of this revision.Jan 19 2021, 3:19 PM

Harbormaster completed remote builds in B85787: Diff 317711.Jan 19 2021, 4:58 PM

sivachandra accepted this revision.Jan 20 2021, 8:45 AM

This revision is now accepted and ready to land.Jan 20 2021, 8:45 AM

In your commit the message does not include Reviewed by:. Many people agree that both Reviewed by: & Differential Revision: should be present. The Reviewed by: list indicates people who acknowledged the patch. (The Reviewers: list does not necessarily mean all the people on the list have acknowledged the patch so Reviewers: is mostly useless.)

arc amend can fetch the Phabricator summary and amend the local description.

You can install llvm/utils/git/pre-push.py to prevent accidental Summary:, Reviewers:, Subscribers: and Tags: in the presence of Differential Revision:.

This change was landed manually since it was too big for arcanist. The change is here and then the follow up change is here.

In D95006#2523159, @michaelrj wrote:

This change was landed manually since it was too big for arcanist. The change is here and then the follow up change is here.

You could use git pull --rebase origin main && git commit --amend --date=now --no-edit && git push origin HEAD:main instead of arc land in that case.

Large Diff

This large diff affects 121 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

Path

Size

libc/

test/

config/

linux/

x86_64/

syscall_test.cpp

2 lines

src/

assert/

assert_test.cpp

4 lines

ctype/

isalnum_test.cpp

2 lines

isalpha_test.cpp

2 lines

isascii_test.cpp

2 lines

isblank_test.cpp

2 lines

iscntrl_test.cpp

2 lines

isdigit_test.cpp

2 lines

isgraph_test.cpp

2 lines

islower_test.cpp

2 lines

isprint_test.cpp

2 lines

ispunct_test.cpp

2 lines

isspace_test.cpp

2 lines

isupper_test.cpp

2 lines

isxdigit_test.cpp

2 lines

toascii_test.cpp

2 lines

tolower_test.cpp

2 lines

toupper_test.cpp

2 lines

errno/

2 lines

fenv/

enabled_exceptions_test.cpp

2 lines

exception_status_test.cpp

2 lines

rounding_mode_test.cpp

2 lines

math/

2 lines

2 lines

14 lines

NextAfterTest.h

6 lines

8 lines

8 lines

8 lines

copysign_test.cpp

4 lines

copysignf_test.cpp

4 lines

copysignl_test.cpp

4 lines

8 lines

10 lines

10 lines

4 lines

4 lines

4 lines

14 lines

16 lines

16 lines

8 lines

floorf_test.cpp

8 lines

floorl_test.cpp

8 lines

10 lines

10 lines

10 lines

10 lines

10 lines

10 lines

10 lines

8 lines

frexpf_test.cpp

8 lines

frexpl_test.cpp

8 lines

10 lines

hypotf_test.cpp

12 lines

10 lines

ilogbf_test.cpp

10 lines

ilogbl_test.cpp

10 lines

8 lines

8 lines

8 lines

8 lines

8 lines

8 lines

8 lines

roundf_test.cpp

8 lines

roundl_test.cpp

8 lines

sincosf_test.cpp

8 lines

10 lines

6 lines

6 lines

6 lines

8 lines

truncf_test.cpp

8 lines

truncl_test.cpp

8 lines

signal/

2 lines

sigaction_test.cpp

8 lines

sigaddset_test.cpp

2 lines

sigdelset_test.cpp

4 lines

sigfillset_test.cpp

4 lines

signal_test.cpp

4 lines

sigprocmask_test.cpp

6 lines

stdio/

fwrite_test.cpp

2 lines

stdlib/

2 lines

2 lines

6 lines

6 lines

6 lines

string/

2 lines

memchr_test.cpp

26 lines

memcmp_test.cpp

8 lines

memcpy_test.cpp

2 lines

memmove_test.cpp

14 lines

memory_utils/

memcpy_utils_test.cpp

14 lines

16 lines

memrchr_test.cpp

24 lines

memset_test.cpp

2 lines

strcat_test.cpp

4 lines

strchr_test.cpp

16 lines

strcmp_test.cpp

14 lines

strcpy_test.cpp

4 lines

strcspn_test.cpp

8 lines

strlen_test.cpp

4 lines

strncpy_test.cpp

10 lines

strnlen_test.cpp

8 lines

strpbrk_test.cpp

16 lines

strrchr_test.cpp

16 lines

strspn_test.cpp

16 lines

strstr_test.cpp

32 lines

strtok_r_test.cpp

15 lines

strtok_test.cpp

16 lines

sys/

mman/

linux/

4 lines

threads/

call_once_test.cpp

4 lines

4 lines

4 lines

time/

mktime_test.cpp

24 lines

unistd/

4 lines

utils/

CPP/

bitset_test.cpp

16 lines

tools/

WrapperGen/

wrappergen_test.cpp

19 lines

utils/

UnitTest/

16 lines

Diff 317711

libc/test/config/linux/x86_64/syscall_test.cpp

libc/test/src/assert/assert_test.cpp

libc/test/src/ctype/isalnum_test.cpp

libc/test/src/ctype/isalpha_test.cpp

libc/test/src/ctype/isascii_test.cpp

libc/test/src/ctype/isblank_test.cpp

libc/test/src/ctype/iscntrl_test.cpp

libc/test/src/ctype/isdigit_test.cpp

libc/test/src/ctype/isgraph_test.cpp

libc/test/src/ctype/islower_test.cpp

libc/test/src/ctype/isprint_test.cpp

libc/test/src/ctype/ispunct_test.cpp

libc/test/src/ctype/isspace_test.cpp

libc/test/src/ctype/isupper_test.cpp

libc/test/src/ctype/isxdigit_test.cpp

libc/test/src/ctype/toascii_test.cpp

libc/test/src/ctype/tolower_test.cpp

libc/test/src/ctype/toupper_test.cpp

libc/test/src/errno/errno_test.cpp

libc/test/src/fenv/enabled_exceptions_test.cpp

libc/test/src/fenv/exception_status_test.cpp

libc/test/src/fenv/rounding_mode_test.cpp

libc/test/src/math/FDimTest.h

libc/test/src/math/ILogbTest.h

libc/test/src/math/LdExpTest.h

libc/test/src/math/NextAfterTest.h

libc/test/src/math/ceil_test.cpp

libc/test/src/math/ceilf_test.cpp

libc/test/src/math/ceill_test.cpp

libc/test/src/math/copysign_test.cpp

libc/test/src/math/copysignf_test.cpp

libc/test/src/math/copysignl_test.cpp

libc/test/src/math/cosf_test.cpp

libc/test/src/math/exp2f_test.cpp

libc/test/src/math/expf_test.cpp

libc/test/src/math/fabs_test.cpp

libc/test/src/math/fabsf_test.cpp

libc/test/src/math/fabsl_test.cpp

libc/test/src/math/fdim_test.cpp

libc/test/src/math/fdimf_test.cpp

libc/test/src/math/fdiml_test.cpp

libc/test/src/math/floor_test.cpp

libc/test/src/math/floorf_test.cpp

libc/test/src/math/floorl_test.cpp

libc/test/src/math/fmaf_test.cpp

libc/test/src/math/fmax_test.cpp

libc/test/src/math/fmaxf_test.cpp

libc/test/src/math/fmaxl_test.cpp

libc/test/src/math/fmin_test.cpp

libc/test/src/math/fminf_test.cpp

libc/test/src/math/fminl_test.cpp

libc/test/src/math/frexp_test.cpp

libc/test/src/math/frexpf_test.cpp

libc/test/src/math/frexpl_test.cpp

libc/test/src/math/hypot_test.cpp

libc/test/src/math/hypotf_test.cpp

libc/test/src/math/ilogb_test.cpp

libc/test/src/math/ilogbf_test.cpp

libc/test/src/math/ilogbl_test.cpp

libc/test/src/math/logb_test.cpp

libc/test/src/math/logbf_test.cpp

libc/test/src/math/logbl_test.cpp

libc/test/src/math/modf_test.cpp

libc/test/src/math/modff_test.cpp

libc/test/src/math/modfl_test.cpp

libc/test/src/math/round_test.cpp

libc/test/src/math/roundf_test.cpp

libc/test/src/math/roundl_test.cpp

libc/test/src/math/sincosf_test.cpp

libc/test/src/math/sinf_test.cpp

libc/test/src/math/sqrt_test.cpp

libc/test/src/math/sqrtf_test.cpp

libc/test/src/math/sqrtl_test.cpp

libc/test/src/math/trunc_test.cpp

libc/test/src/math/truncf_test.cpp

libc/test/src/math/truncl_test.cpp

libc/test/src/signal/raise_test.cpp

libc/test/src/signal/sigaction_test.cpp

libc/test/src/signal/sigaddset_test.cpp

libc/test/src/signal/sigdelset_test.cpp

libc/test/src/signal/sigfillset_test.cpp

libc/test/src/signal/signal_test.cpp

libc/test/src/signal/sigprocmask_test.cpp

libc/test/src/stdio/fwrite_test.cpp

libc/test/src/stdlib/_Exit_test.cpp

libc/test/src/stdlib/abort_test.cpp

libc/test/src/stdlib/abs_test.cpp

libc/test/src/stdlib/labs_test.cpp

libc/test/src/stdlib/llabs_test.cpp

libc/test/src/string/bzero_test.cpp

libc/test/src/string/memchr_test.cpp

libc/test/src/string/memcmp_test.cpp

libc/test/src/string/memcpy_test.cpp

libc/test/src/string/memmove_test.cpp

libc/test/src/string/memory_utils/memcpy_utils_test.cpp

libc/test/src/string/memory_utils/utils_test.cpp

libc/test/src/string/memrchr_test.cpp

libc/test/src/string/memset_test.cpp

libc/test/src/string/strcat_test.cpp

libc/test/src/string/strchr_test.cpp

libc/test/src/string/strcmp_test.cpp

libc/test/src/string/strcpy_test.cpp

libc/test/src/string/strcspn_test.cpp

libc/test/src/string/strlen_test.cpp

libc/test/src/string/strncpy_test.cpp

libc/test/src/string/strnlen_test.cpp

libc/test/src/string/strpbrk_test.cpp

libc/test/src/string/strrchr_test.cpp

libc/test/src/string/strspn_test.cpp

libc/test/src/string/strstr_test.cpp

libc/test/src/string/strtok_r_test.cpp

libc/test/src/string/strtok_test.cpp

libc/test/src/sys/mman/linux/mmap_test.cpp

libc/test/src/threads/call_once_test.cpp

libc/test/src/threads/mtx_test.cpp

libc/test/src/threads/thrd_test.cpp

libc/test/src/time/mktime_test.cpp

libc/test/src/unistd/write_test.cpp

libc/test/utils/CPP/bitset_test.cpp

libc/test/utils/tools/WrapperGen/wrappergen_test.cpp

libc/utils/UnitTest/LibcTest.h