Page MenuHomePhabricator

[libc][NFC] add "LlvmLibc" as a prefix to all test names
ClosedPublic

Authored by michaelrj on Jan 19 2021, 3:19 PM.

Details

Reviewers
sivachandra
Summary

Having a consistent prefix makes selecting all of the llvm libc tests
easier on any platform that is also using the gtest framework.
This also modifies the TEST and TEST_F macros to enforce this change
moving forward.

Diff Detail

Event Timeline

michaelrj created this revision.Jan 19 2021, 3:19 PM
michaelrj requested review of this revision.Jan 19 2021, 3:19 PM
sivachandra accepted this revision.Jan 20 2021, 8:45 AM
This revision is now accepted and ready to land.Jan 20 2021, 8:45 AM
MaskRay added a subscriber: MaskRay.EditedTue, Jan 26, 9:15 AM

In your commit the message does not include Reviewed by:. Many people agree that both Reviewed by: & Differential Revision: should be present. The Reviewed by: list indicates people who acknowledged the patch. (The Reviewers: list does not necessarily mean all the people on the list have acknowledged the patch so Reviewers: is mostly useless.)

arc amend can fetch the Phabricator summary and amend the local description.

You can install llvm/utils/git/pre-push.py to prevent accidental Summary:, Reviewers:, Subscribers: and Tags: in the presence of Differential Revision:.

michaelrj closed this revision.Tue, Jan 26, 10:08 AM

This change was landed manually since it was too big for arcanist. The change is here and then the follow up change is here.

This change was landed manually since it was too big for arcanist. The change is here and then the follow up change is here.

You could use git pull --rebase origin main && git commit --amend --date=now --no-edit && git push origin HEAD:main instead of arc land in that case.