Having a consistent prefix makes selecting all of the llvm libc tests
easier on any platform that is also using the gtest framework.
This also modifies the TEST and TEST_F macros to enforce this change
moving forward.
Details
- Reviewers
sivachandra
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
In your commit the message does not include Reviewed by:. Many people agree that both Reviewed by: & Differential Revision: should be present. The Reviewed by: list indicates people who acknowledged the patch. (The Reviewers: list does not necessarily mean all the people on the list have acknowledged the patch so Reviewers: is mostly useless.)
arc amend can fetch the Phabricator summary and amend the local description.
You can install llvm/utils/git/pre-push.py to prevent accidental Summary:, Reviewers:, Subscribers: and Tags: in the presence of Differential Revision:.
You could use git pull --rebase origin main && git commit --amend --date=now --no-edit && git push origin HEAD:main instead of arc land in that case.
clang-tidy: warning: invalid case style for function 'same_prefix' [readability-identifier-naming]
not useful
clang-tidy: warning: invalid case style for parameter 'lhs' [readability-identifier-naming]
not useful
clang-tidy: warning: invalid case style for parameter 'rhs' [readability-identifier-naming]
not useful
clang-tidy: warning: invalid case style for parameter 'len' [readability-identifier-naming]
not useful