This is an archive of the discontinued LLVM Phabricator instance.

Remove nonsensical fct definition
ClosedPublic

Authored by thopre on Jan 15 2021, 3:54 PM.

Reviewers

Summary

Aggregation's getvalue function has a nonsensical definition and is thus
not used by anything. This commit removes it.

Build Status

Buildable 85442
Build 116677: arc lint + arc unit

thopre requested review of this revision.Jan 15 2021, 3:54 PM

This revision is now accepted and ready to land.Jan 16 2021, 5:25 AM

Path

Size

lnt/

server/

reporting/

3 lines

	import re			import re

	import lnt.testing			import lnt.testing
	import lnt.util.stats			import lnt.util.stats

	###			###
	# Aggregation Function			# Aggregation Function


	class Aggregation(object):			class Aggregation(object):
	def __init__(self):			def __init__(self):
	self.is_initialized = False			self.is_initialized = False

	def __repr__(self):			def __repr__(self):
	return repr(self.getvalue())			return repr(self.getvalue())

	def getvalue(self):
	abstract

	def append(self, values):			def append(self, values):
	if not self.is_initialized:			if not self.is_initialized:
	self.is_initialized = True			self.is_initialized = True
	self._initialize(values)			self._initialize(values)
	self._append(values)			self._append(values)


	class Sum(Aggregation):			class Sum(Aggregation):
	▲ Show 20 Lines • Show All 476 Lines • Show Last 20 Lines