This is an archive of the discontinued LLVM Phabricator instance.

skip g packet tests on darwin systems
ClosedPublic

Authored by jasonmolenda on Jan 15 2021, 1:22 AM.

Details

Summary

debugserver doesn't support the g packet. I don't understand how this test runs in the first place; the main.cpp in this directory won't compile with clang on Darwin systems - the alignas(16) type specifier isn't recognized? - but it then fails when it compares some bytes it got (from where??) and doesn't get matching values,

First differing element 0:
0x020406080a0c0e01
0x0000000000000000

  • ['0x020406080a0c0e01', '0x030507090b0d0f00']

+ ['0x0000000000000000', '0x0000000000000000']

somehow the earlier tests passed I guess.

Well, there's a lot I don't understand here, but I do know that debugserver doesn't support the g packet and debugserver is the only way to debug processes on darwin, so we should skip.

Pavel, is this OK with you?

Diff Detail

Event Timeline

jasonmolenda created this revision.Jan 15 2021, 1:22 AM
jasonmolenda requested review of this revision.Jan 15 2021, 1:22 AM

Ah, part of my confusion is mine - the alignas() requires c++11 and I wasn't building with that mode when I did it by hand.

Ah, Pavel's change was correct to run the first test.

labath accepted this revision.Jan 15 2021, 9:11 AM

Yeah, this is fine. I remember running this on darwin and noticing that debugserver only supports G (and lldb-server, amusingly, only supports g). I must have forgotten to add the decorators when copying patches around. Sorry.

This revision is now accepted and ready to land.Jan 15 2021, 9:11 AM