skip g packet tests on darwin systems

[jasonmolenda]

Summary

debugserver doesn't support the g packet. I don't understand how this test runs in the first place; the main.cpp in this directory won't compile with clang on Darwin systems - the alignas(16) type specifier isn't recognized? - but it then fails when it compares some bytes it got (from where??) and doesn't get matching values,

First differing element 0:
0x020406080a0c0e01
0x0000000000000000

• ['0x020406080a0c0e01', '0x030507090b0d0f00']

+ ['0x0000000000000000', '0x0000000000000000']

somehow the earlier tests passed I guess.

Well, there's a lot I don't understand here, but I do know that debugserver doesn't support the g packet and debugserver is the only way to debug processes on darwin, so we should skip.

Pavel, is this OK with you?

[jasonmolenda]

Ah, part of my confusion is mine - the alignas() requires c++11 and I wasn't building with that mode when I did it by hand.

[jasonmolenda]

Ah, Pavel's change was correct to run the first test.

[labath]

Yeah, this is fine. I remember running this on darwin and noticing that debugserver only supports G (and lldb-server, amusingly, only supports g). I must have forgotten to add the decorators when copying patches around. Sorry.

lldb/test/API/tools/lldb-server/register-reading/TestGdbRemoteGPacket.py

     mydir = TestBase.compute_mydir(__file__)
 
     @skipIfOutOfTreeDebugserver
-    @skipUnlessDarwin # G packet not supported
+    @skipIfDarwin # g packet not supported
     def test_g_packet(self):
         self.build()
         self.prep_debug_monitor_and_inferior()

 
     @expectedFailureAll(oslist=["freebsd"], bugnumber="llvm.org/pr48420")
     @expectedFailureNetBSD
+    @skipIfDarwin # g packet not supported
     def test_g_returns_correct_data_with_suffix(self):
         self.build()
         self.set_inferior_startup_launch()

 
     @expectedFailureAll(oslist=["freebsd"], bugnumber="llvm.org/pr48420")
     @expectedFailureNetBSD
+    @skipIfDarwin # g packet not supported
     def test_g_returns_correct_data_no_suffix(self):
         self.build()
         self.set_inferior_startup_launch()