This is an archive of the discontinued LLVM Phabricator instance.

Differential D94725

[OpenMP] Remove omptarget-nvptx from deps as it is no longer a valid target
ClosedPublic

Authored by tianshilei1992 on Jan 14 2021, 2:27 PM.

Details

Reviewers
jdoerfert
JonChesterfield
Commits
rG547b032ccc8e: [OpenMP] Remove omptarget-nvptx from deps as it is no longer a valid target
Summary

omptarget-nvptx is still a dependence for check-libomptarget-nvtpx
although it has been removed by D94573.

Diff Detail

Event Timeline

tianshilei1992 created this revision.Jan 14 2021, 2:27 PM
Herald added subscribers: guansong, yaxunl, mgorny. · View Herald TranscriptJan 14 2021, 2:27 PM
tianshilei1992 requested review of this revision.Jan 14 2021, 2:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 14 2021, 2:27 PM
Herald added subscribers: openmp-commits, sstefan1. · View Herald Transcript
JonChesterfield accepted this revision.Jan 14 2021, 2:50 PM

Thanks!

This revision is now accepted and ready to land.Jan 14 2021, 2:50 PM
Harbormaster completed remote builds in B85249: Diff 316784.Jan 14 2021, 3:15 PM
Closed by commit rG547b032ccc8e: [OpenMP] Remove omptarget-nvptx from deps as it is no longer a valid target (authored by tianshilei1992). · Explain WhyJan 14 2021, 4:16 PM
This revision was automatically updated to reflect the committed changes.
tianshilei1992 added a commit: rG547b032ccc8e: [OpenMP] Remove omptarget-nvptx from deps as it is no longer a valid target.

Revision Contents

PathSize
openmp/
libomptarget/
deviceRTLs/
nvptx/
test/
2 lines

Diff 316802

openmp/libomptarget/deviceRTLs/nvptx/test/CMakeLists.txt

if(NOT OPENMP_TEST_COMPILER_ID STREQUAL "Clang") if(NOT OPENMP_TEST_COMPILER_ID STREQUAL "Clang")
# Silently return, no need to annoy the user. # Silently return, no need to annoy the user.
return() return()
endif() endif()
set(deps omptarget-nvptx omptarget omp) set(deps omptarget omp)
if(LIBOMPTARGET_NVPTX_ENABLE_BCLIB) if(LIBOMPTARGET_NVPTX_ENABLE_BCLIB)
set(deps ${deps} omptarget-nvptx-bc) set(deps ${deps} omptarget-nvptx-bc)
endif() endif()
# Run with only one thread to only launch one application to the GPU at a time. # Run with only one thread to only launch one application to the GPU at a time.
add_openmp_testsuite(check-libomptarget-nvptx add_openmp_testsuite(check-libomptarget-nvptx
"Running libomptarget-nvptx tests" ${CMAKE_CURRENT_BINARY_DIR} "Running libomptarget-nvptx tests" ${CMAKE_CURRENT_BINARY_DIR}
EXCLUDE_FROM_CHECK_ALL EXCLUDE_FROM_CHECK_ALL
Show All 11 Lines