Fix all unused imports flake8 warnings

[thopre]

Summary

lnt/lnttool/main.py:

• ignore flask.current_app and flask.g unused import warnings since they are used through locals() below

lnt/lnttool/__init__.py:

• ignore main.main unused import warning since it is LNT's entry point

tests/testing/cPerf.py:

• ignore lnt.testing.profile.cPerf import warning since the import is used to avoid a failing test if cPerf is not available

lnt/server/ui/views.py and lnt/server/ui/regression_views.py:

• remove flask.redirect imports which are no longer used since cc9b7c48f8e22c1b883950ef214bb710c85ca412

lnt/server/ui/globals.py:

• remove lnt.server.ui.util unused import which is no longer used since 808245434195310a3a842cceaccc93d879d00a18

lnt/server/ui/decorators.py:

• remove flask.render_template unused import which is no longer used since f5fa093be57e7b9ab561a27c988f7a5e6bb53a4b

lnt/server/db/v4db.py:

• remove sqlalchemy.orm.joinedload unused import which is no longer used since d464dd2acb1b1ff95b315848af1bb45db322096a

lnt/server/db/testsuitedb.py:

• remove typing.List unused import which is no longer used since b9d4622cb14fd0f407431df95134b120004f2f8a

lnt/server/db/migrations/upgrade_2_to_3.py,
lnt/server/db/migrations/upgrade_7_to_8.py,
lnt/server/db/migrations/upgrade_8_to_9.py and
lnt/server/db/migrations/upgrade_10_to_11.py:

• remove sqlalchemy.orm.relation unused import which was never needed

lnt/server/db/migrations/upgrade_12_to_13.py:

• remove sqlalchemy unused import which stopped being used after c6c4b5dcf1dedd9ac2fab5d405fa2e309b41d156 (doh!)

lnt/server/db/migrations/upgrade_14_to_15.py:

• remove lnt.server.db.migrations.util.rename_table unused import which was never needed

lnt/server/db/rules/rule_update_profile_stats.py:

• remove datetime unused import which was never needed

tests/testing/cPerf.py:

• remove time, threading and json unused import which were never needed

tests/server/db/search.py:

• remove logging unused import which is no longer used since 48bc5fcbdabb7b24ef56e4271a5f5d0e5326d4f4
• remove contextlib unused import which was never needed

tests/server/db/CreateV4TestSuite.py:

• remove sys unused import which was never needed

tests/server/db/CreateV4TestSuiteInstance.py:

• remove lnt.server.db.testsuite unused import which is no longer used since 7f585029766b78ad2dd68083399bdd4e2755fdab

[cmatthews]

Could you put your analysis of why the noqa is needed in the noqa comments, so that it will be easy to understand from looking at the code?

[thopre]

Explain reason for noqa inline

[thopre]

Rebase on top of D94715

lnt/lnttool/__init__.py

 from __future__ import absolute_import
-from .main import main
+from .main import main  # noqa: F401

lnt/lnttool/main.py

if profiler:
         import werkzeug.contrib.profiler
         if profiler_dir:
             if not os.path.isdir(profiler_dir):
                 os.mkdir(profiler_dir)
         app.wsgi_app = werkzeug.contrib.profiler.ProfilerMiddleware(
             app.wsgi_app, stream=open(profiler_file, 'w'),
             profile_dir=profiler_dir)
     if shell:
-        from flask import current_app
-        from flask import g
+        from flask import current_app  # noqa: F401
+        from flask import g  # noqa: F401
         import code
         ctx = app.test_request_context()
         ctx.push()
 
         vars = globals().copy()
         vars.update(locals())
         shell = code.InteractiveConsole(vars)
         shell.interact()

lnt/server/db/migrations/upgrade_10_to_11.py

 # Version 8 of the database updates FieldChanges as well as adds tables
 # for Regression Tracking features.
 
 import sqlalchemy
 from sqlalchemy import String, Integer, Column, ForeignKey
-from sqlalchemy.orm import relation
 
 # Import the original schema from upgrade_0_to_1 since upgrade_1_to_2 does not
 # change the actual schema, but rather adds functionality vis-a-vis orders.
 import lnt.server.db.migrations.upgrade_0_to_1 as upgrade_0_to_1
 
 import lnt.server.db.migrations.upgrade_7_to_8 as upgrade_7_to_8
 
 

lnt/server/db/migrations/upgrade_12_to_13.py

 # Adds new table to store jsonschema previously used to construct testsuite.
-import sqlalchemy
 from sqlalchemy.ext.declarative import declarative_base
 from sqlalchemy import Column, String, Binary
 
 Base = declarative_base()
 
 
 class TestSuiteJSONSchema(Base):
     __tablename__ = "TestSuiteJSONSchemas"
     testsuite_name = Column("TestSuiteName", String(256), primary_key=True)
     jsonschema = Column("JSONSchema", Binary)
 
 
 def upgrade(engine):
     Base.metadata.create_all(engine)

lnt/server/db/migrations/upgrade_14_to_15.py

 # Drop the "FieldChange" tables; they have been deprecated and replaced by
 # "FieldChangeV2" for a long while now (but can still cause trouble when trying
 # to delete old runs that are referenced from a FieldChange entry).
-from lnt.server.db.migrations.util import introspect_table, rename_table
+from lnt.server.db.migrations.util import introspect_table
 
 
 def update_testsuite(engine, db_key_name):
     table_name = '%s_FieldChange' % db_key_name
     with engine.begin() as trans:
         table = introspect_table(engine, table_name, autoload=False)
         table.drop(checkfirst=True)
 
 
 def upgrade(engine):
     update_testsuite(engine, 'NT')
     update_testsuite(engine, 'compile')

lnt/server/db/migrations/upgrade_2_to_3.py

 # Version 3 of the database adds the FieldChange class to track flagged
 # regressions in the database.
 
 import sqlalchemy
 from sqlalchemy import Integer, Column, ForeignKey
-from sqlalchemy.orm import relation
 
 # Import the original schema from upgrade_0_to_1 since upgrade_1_to_2 does not
 # change the actual schema, but rather adds functionality vis-a-vis orders.
 import lnt.server.db.migrations.upgrade_0_to_1 as upgrade_0_to_1
 
 ###
 # Upgrade TestSuite
 

lnt/server/db/migrations/upgrade_7_to_8.py

 # Version 8 of the database updates FieldChanges as well as adds tables
 # for Regression Tracking features.
 
 import sqlalchemy
 from sqlalchemy import Float, String, Integer, Column, ForeignKey
-from sqlalchemy.orm import relation
 
 # Import the original schema from upgrade_0_to_1 since upgrade_1_to_2 does not
 # change the actual schema, but rather adds functionality vis-a-vis orders.
 import lnt.server.db.migrations.upgrade_0_to_1 as upgrade_0_to_1
 import lnt.server.db.migrations.upgrade_2_to_3 as upgrade_2_to_3
 
 
 ###

lnt/server/db/migrations/upgrade_8_to_9.py

 # Version 9 of the database updates Sample to add the profile field, and
 # adds Profiles.
 
 import sqlalchemy
 from sqlalchemy import String, Integer, Column, DateTime
-from sqlalchemy.orm import relation
 
 # Import the original schema from upgrade_0_to_1 since upgrade_1_to_2 does not
 # change the actual schema, but rather adds functionality vis-a-vis orders.
 import lnt.server.db.migrations.upgrade_0_to_1 as upgrade_0_to_1
 import lnt.server.db.migrations.upgrade_2_to_3 as upgrade_2_to_3
 from lnt.server.db.util import add_column
 
 

lnt/server/db/rules/rule_update_profile_stats.py

 """
 Post submission hook to write the current state of the profiles directory. This
 gets fed into the profile/admin page.
 """
-import datetime
 import glob
 import json
 import os
 import subprocess
 import time
 
 
 def update_profile_stats(session, ts, run_id):

lnt/server/db/testsuitedb.py

 import itertools
 
 import aniso8601
 import sqlalchemy
 import flask
 from sqlalchemy import Float, String, Integer, Column, ForeignKey, Binary, DateTime
 from sqlalchemy.orm import relation
 from sqlalchemy.orm.exc import ObjectDeletedError
-from typing import List
 from lnt.util import logger
 
 from . import testsuite
 import lnt.testing.profile.profile as profile
 import lnt
 from lnt.server.ui.util import convert_revision
 
 

lnt/server/db/v4db.py

 import glob
 import yaml
 
 import sqlalchemy
 
 import lnt.testing
 
 import lnt.server.db.testsuitedb
 import lnt.server.db.migrate
 
 from lnt.server.db import testsuite
-from sqlalchemy.orm import joinedload
 import lnt.server.db.util
 
 
 class V4DB(object):
     """
     Wrapper object for LNT v0.4+ databases.
     """
     def _load_schema_file(self, schema_file):

lnt/server/ui/decorators.py

 import flask
 from flask import abort
-from flask import current_app, g, render_template
+from flask import current_app, g
 from flask import request
 
 frontend = flask.Blueprint("lnt", __name__, template_folder="ui/templates/",
                            static_folder="ui/static")
 
 
 def _make_db_session(db_name):
     # Initialize the database parameters on the app globals object.

lnt/server/ui/globals.py

 """
 Module for defining additional Jinja global functions.
 """
 
 import flask
 from flask import Response
 
-import lnt.server.ui.util
-
 
 def db_url_for(*args, **kwargs):
     """
     Like url_for, but handles automatically providing the db_name argument.
     """
     return flask.url_for(*args, db_name=flask.g.db_name, **kwargs)
 
 

lnt/server/ui/regression_views.py

 import flask
 import sqlalchemy
 import json
 from flask import g
 from flask import abort
 from flask import render_template
 from flask import request
 from flask import flash
-from flask import redirect
 from sqlalchemy import desc
 from sqlalchemy.orm.exc import NoResultFound
 from wtforms import SelectMultipleField, StringField, widgets, SelectField
 from wtforms import HiddenField
 from flask_wtf import Form
 from wtforms.validators import DataRequired
 
 from lnt.server.ui.decorators import v4_route

lnt/server/ui/views.py

 
 import flask
 import sqlalchemy.sql
 from flask import abort
 from flask import current_app
 from flask import flash
 from flask import g
 from flask import make_response
-from flask import redirect
 from flask import render_template
 from flask import request, url_for
 from flask_wtf import Form
 from sqlalchemy.orm import joinedload
 from sqlalchemy.orm.exc import NoResultFound
 from typing import List, Optional
 from wtforms import SelectField, StringField, SubmitField
 from wtforms.validators import DataRequired, Length

tests/server/db/CreateV4TestSuite.py

 # This test just checks that we can construct and manipulate the test suite
 # model itself. The heavy lifting of constructing a test suite's databases,
 # etc. is checked in CreateV4TestSuiteInstance.
 #
 # RUN: rm -f %t.db
 # RUN: python %s %t.db
 
-import sys
 from lnt.server.config import Config
 from lnt.server.db import testsuite
 from lnt.server.db import v4db
 
 # Create an in memory database.
 db = v4db.V4DB("sqlite:///:memory:", Config.dummy_instance())
 session = db.make_session()
 

tests/server/db/CreateV4TestSuiteInstance.py

 # Check the model bindings for test suite instances.
 #
 # RUN: rm -f %t.db
 # RUN: python %s %t.db
 
 import datetime
 
 from lnt.server.config import Config
-from lnt.server.db import testsuite
 from lnt.server.db import v4db
 from lnt.server.db.fieldchange import RegressionState
 
 # Create an in memory database.
 db = v4db.V4DB("sqlite:///:memory:", Config.dummy_instance())
 session = db.make_session()
 
 # Get the test suite wrapper.

tests/server/db/search.py

 # RUN: python %s %S
 
-import unittest, tempfile, shutil, logging, sys, os, contextlib
+import unittest, tempfile, shutil, sys, os
 import lnt.util.ImportData
 import lnt.server.instance
 from lnt.server.db.search import search
 
 
 base_path = ''
 
 

tests/testing/cPerf.py

 # RUN: python %s
-import unittest, sys, os, tempfile, time, threading, json
+import unittest, sys, os, tempfile
 
 try:
-    import lnt.testing.profile.cPerf as cPerf
+    import lnt.testing.profile.cPerf as cPerf  # noqa: F401
 except:
     # No tests to run if cPerf is not available
     sys.exit(0)
 
 from lnt.testing.profile.perf import LinuxPerfProfile
     
 class CPerfTest(unittest.TestCase):
     def setUp(self):