This is an archive of the discontinued LLVM Phabricator instance.

Expect LNT to be installed in the tests
ClosedPublic

Authored by thopre on Jan 14 2021, 12:56 PM.

Details

Summary

LNT's lit is configured to be able to run the tests without LNT being
installed. This is useful for testing/cPerf.py which skips all its
checks if cPerf extension is not found, which happens when setup has not
run and thus it has not been built.

However newly added runtest/test_suite-profile.shtest expects cPerf
being installed or its globbing fails. This seems a better approach
because a patch author risks missing a regression if some tests are
skipped. Therefore this commit removes the root of the repository from
the PYTHONPATH in lit's config, thereby requiring the user running the
test having lit in PYTHONPATH.

Event Timeline

thopre created this revision.Jan 14 2021, 12:56 PM
thopre requested review of this revision.Jan 14 2021, 12:56 PM
tnfchris accepted this revision.Jan 14 2021, 1:08 PM

I agree, this makes more sense so we don't break cPerf again.

This revision is now accepted and ready to land.Jan 14 2021, 1:08 PM
thopre closed this revision.Jan 14 2021, 1:46 PM