This is an archive of the discontinued LLVM Phabricator instance.

Differential D94660

[llvm-readobj][test] - Remove excessive YAML fields from tests.
ClosedPublic

Authored by grimar on Jan 14 2021, 1:36 AM.

Details

Reviewers
jhenderson
MaskRay
• espindola
Commits
rG45ef053bd709: [llvm-readobj][test] - Remove excessive YAML fields from tests.
Summary

This removes excessive YAML keys from SHT_GNU_verdef sections.
Those keys are set by default.

Depends on D94659.

Diff Detail

Event Timeline

grimar created this revision.Jan 14 2021, 1:36 AM
Herald added a reviewer: • espindola. · View Herald TranscriptJan 14 2021, 1:36 AM
Herald added subscribers: rupprecht, emaste. · View Herald Transcript
grimar requested review of this revision.Jan 14 2021, 1:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 14 2021, 1:36 AM
jhenderson accepted this revision.Jan 14 2021, 2:50 AM

Looks good.

This revision is now accepted and ready to land.Jan 14 2021, 2:50 AM
Closed by commit rG45ef053bd709: [llvm-readobj][test] - Remove excessive YAML fields from tests. (authored by grimar). · Explain WhyJan 15 2021, 1:53 AM
This revision was automatically updated to reflect the committed changes.
grimar added a commit: rG45ef053bd709: [llvm-readobj][test] - Remove excessive YAML fields from tests..

Revision Contents

PathSize
llvm/
test/
tools/
llvm-readobj/
ELF/
10 lines
29 lines
27 lines

Diff 316590

llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test

Show First 20 Lines • Show All 302 Lines • ▼ Show 20 Lines## 0x8000 is a special VERSYM_HIDDEN bit.
Entries: [ 0, 1, 2, 0x8003 ] Entries: [ 0, 1, 2, 0x8003 ]
- Name: .gnu.version_d - Name: .gnu.version_d
Type: SHT_GNU_verdef Type: SHT_GNU_verdef
Flags: [ SHF_ALLOC ] Flags: [ SHF_ALLOC ]
Link: .dynstr Link: .dynstr
AddressAlign: 0x4 AddressAlign: 0x4
Info: 0x2 Info: 0x2
Entries: Entries:
- Version: 1 - VersionNdx: 2
Flags: 0
VersionNdx: 2
Hash: 0
Names: Names:
- Default - Default
- Version: 1 - VersionNdx: 3
Flags: 0
VersionNdx: 3
Hash: 0
Names: Names:
- NonDefault - NonDefault
DynamicSymbols: DynamicSymbols:
- Name: foo - Name: foo
- Name: [[NAME=bar]] - Name: [[NAME=bar]]
Type: [[TYPE=STT_NOTYPE]] Type: [[TYPE=STT_NOTYPE]]
Index: [[INDEX=<none>]] Index: [[INDEX=<none>]]
- Name: [[NAME=zed]] - Name: [[NAME=zed]]
▲ Show 20 Lines • Show All 385 Lines • Show Last 20 Lines

llvm/test/tools/llvm-readobj/ELF/verdef-invalid.test

Show First 20 Lines • Show All 101 Lines • ▼ Show 20 LinesFileHeader:
Data: ELFDATA2LSB Data: ELFDATA2LSB
Type: ET_DYN Type: ET_DYN
Sections: Sections:
- Name: .gnu.version_d - Name: .gnu.version_d
Type: SHT_GNU_verdef Type: SHT_GNU_verdef
Link: .dynstr Link: .dynstr
Info: 0x1 Info: 0x1
Entries: Entries:
- Version: 1 - Names:
Flags: 0
VersionNdx: 0
Hash: 0
Names:
- FOO - FOO
ShSize: 1 ShSize: 1
DynamicSymbols: DynamicSymbols:
- Name: foo - Name: foo
## Check that we report a warning when a SHT_GNU_verdef section contains a version definition ## Check that we report a warning when a SHT_GNU_verdef section contains a version definition
## that refers to an auxiliary entry that goes past the end of the section. ## that refers to an auxiliary entry that goes past the end of the section.
Show All 9 LinesFileHeader:
Data: ELFDATA2LSB Data: ELFDATA2LSB
Type: ET_DYN Type: ET_DYN
Sections: Sections:
- Name: .gnu.version_d - Name: .gnu.version_d
Type: SHT_GNU_verdef Type: SHT_GNU_verdef
Link: .dynstr Link: .dynstr
Info: 0x1 Info: 0x1
Entries: Entries:
- Version: 1 - Names:
Flags: 0
VersionNdx: 0
Hash: 0
Names:
- FOO - FOO
ShSize: 21 ShSize: 21
DynamicSymbols: DynamicSymbols:
- Name: foo - Name: foo
## Check that we can dump a SHT_GNU_verdef section properly even if it contains version names strings ## Check that we can dump a SHT_GNU_verdef section properly even if it contains version names strings
## that overrun the linked string table. ## that overrun the linked string table.
Show All 23 LinesFileHeader:
Data: ELFDATA2LSB Data: ELFDATA2LSB
Type: ET_DYN Type: ET_DYN
Sections: Sections:
- Name: .gnu.version_d - Name: .gnu.version_d
Type: SHT_GNU_verdef Type: SHT_GNU_verdef
Link: .strtab Link: .strtab
Info: 0x1 Info: 0x1
Entries: Entries:
- Version: 1 - Names:
Flags: 0
VersionNdx: 0
Hash: 0
Names:
- FOO - FOO
- Name: .strtab - Name: .strtab
Type: SHT_STRTAB Type: SHT_STRTAB
DynamicSymbols: DynamicSymbols:
- Name: BAR - Name: BAR
## Check we report a warning when a version definition is not correctly aligned in memory. ## Check we report a warning when a version definition is not correctly aligned in memory.
Show All 11 Lines
Sections: Sections:
- Type: Fill - Type: Fill
Size: 0x1 Size: 0x1
- Name: .gnu.version_d - Name: .gnu.version_d
Type: SHT_GNU_verdef Type: SHT_GNU_verdef
Link: .dynstr Link: .dynstr
Info: 0x1 Info: 0x1
Entries: Entries:
- Version: 1 - Names:
Flags: 0
VersionNdx: 0
Hash: 0
Names:
- FOO - FOO
DynamicSymbols: DynamicSymbols:
- Name: foo - Name: foo
## Check we report a warning when an auxiliary entry is not correctly aligned in memory. ## Check we report a warning when an auxiliary entry is not correctly aligned in memory.
# RUN: yaml2obj %s --docnum=7 -o %t8 # RUN: yaml2obj %s --docnum=7 -o %t8
# RUN: llvm-readobj -V %t8 2>&1 | FileCheck %s --check-prefix=MISALIGNED-AUX -DFILE=%t8 # RUN: llvm-readobj -V %t8 2>&1 | FileCheck %s --check-prefix=MISALIGNED-AUX -DFILE=%t8
Show All 32 LinesFileHeader:
Data: ELFDATA2LSB Data: ELFDATA2LSB
Type: ET_DYN Type: ET_DYN
Sections: Sections:
- Name: .gnu.version_d - Name: .gnu.version_d
Type: SHT_GNU_verdef Type: SHT_GNU_verdef
Link: .dynstr Link: .dynstr
Info: 0x1 Info: 0x1
Entries: Entries:
- Version: 0xfefe - Version: 0xfefe
Flags: 0
VersionNdx: 0
Hash: 0
Names: [] Names: []
DynamicSymbols: DynamicSymbols:
- Name: foo - Name: foo
## Check we report a warning when trying to print version symbols, but SHT_GNU_verdef ## Check we report a warning when trying to print version symbols, but SHT_GNU_verdef
## is invalid due to any reason. ## is invalid due to any reason.
# RUN: yaml2obj %s --docnum=9 -o %t10 # RUN: yaml2obj %s --docnum=9 -o %t10
▲ Show 20 Lines • Show All 41 Lines • Show Last 20 Lines

llvm/test/tools/llvm-readobj/ELF/versioninfo.test

Show All 21 Lines - Name: .gnu.version
Entries: [ 0, 2, 3, 4, 5, 6] Entries: [ 0, 2, 3, 4, 5, 6]
- Name: .gnu.version_d - Name: .gnu.version_d
Type: SHT_GNU_verdef Type: SHT_GNU_verdef
Flags: [ SHF_ALLOC ] Flags: [ SHF_ALLOC ]
Link: .dynstr Link: .dynstr
AddressAlign: 0x0000000000000004 AddressAlign: 0x0000000000000004
Info: 0x0000000000000006 Info: 0x0000000000000006
Entries: Entries:
- Version: 1 - Names:
Flags: 0
VersionNdx: 0
Hash: 0
Names:
- VERSION1 - VERSION1
- Version: 1 - Flags: 1
Flags: 1
VersionNdx: 0
Hash: 0
Names: Names:
- VERSION1 - VERSION1
- Version: 1 - Flags: 2
Flags: 2
VersionNdx: 0
Hash: 0
Names: Names:
- VERSION1 - VERSION1
- Version: 1 - Flags: 4
Flags: 4
VersionNdx: 0
Hash: 0
Names: Names:
- VERSION1 - VERSION1
- Version: 1 - Flags: 7
Flags: 7
VersionNdx: 2 VersionNdx: 2
Hash: 175630257 Hash: 175630257
Names: Names:
- VERSION1 - VERSION1
- Version: 1 - Flags: 8
Flags: 8
VersionNdx: 3 VersionNdx: 3
Hash: 175630258 Hash: 175630258
Names: Names:
- VERSION2 - VERSION2
- VERSION1 - VERSION1
- VERSION3 - VERSION3
- Name: .gnu.version_r - Name: .gnu.version_r
Type: SHT_GNU_verneed Type: SHT_GNU_verneed
▲ Show 20 Lines • Show All 227 Lines • Show Last 20 Lines