This is an archive of the discontinued LLVM Phabricator instance.

Differential D94616

[NFC] Disallow unused prefixes under MC/AArch64
ClosedPublic

Authored by mtrofin on Jan 13 2021, 10:40 AM.

Details

Reviewers
pratlucas
Commits
rG35c8a6cbf5ff: [NFC] Disallow unused prefixes under MC/AArch64

Diff Detail

Event Timeline

mtrofin created this revision.Jan 13 2021, 10:40 AM
Herald added subscribers: danielkiss, kristof.beyls. · View Herald TranscriptJan 13 2021, 10:40 AM
mtrofin requested review of this revision.Jan 13 2021, 10:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 13 2021, 10:40 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B85048: Diff 316448.Jan 13 2021, 11:37 AM
pratlucas accepted this revision.Jan 14 2021, 1:39 AM

LGTM.

This revision is now accepted and ready to land.Jan 14 2021, 1:39 AM
Closed by commit rG35c8a6cbf5ff: [NFC] Disallow unused prefixes under MC/AArch64 (authored by mtrofin). · Explain WhyJan 14 2021, 9:46 AM
This revision was automatically updated to reflect the committed changes.
mtrofin added a commit: rG35c8a6cbf5ff: [NFC] Disallow unused prefixes under MC/AArch64.

Revision Contents

PathSize
llvm/
test/
MC/
AArch64/
4 lines
6 lines
8 lines

Diff 316688

llvm/test/MC/AArch64/armv8.7a-ls64.s

// RUN: not llvm-mc -triple aarch64-none-linux-gnu -show-encoding -mattr=+ls64 < %s 2>%t | FileCheck %s // RUN: not llvm-mc -triple aarch64-none-linux-gnu -show-encoding -mattr=+ls64 < %s 2>%t | FileCheck %s
// RUN: FileCheck --check-prefix=CHECK-ERR --check-prefix=CHECK-LS64-ERR %s < %t // RUN: FileCheck --check-prefix=CHECK-ERR %s < %t
// RUN: not llvm-mc -triple aarch64-none-linux-gnu < %s 2> %t // RUN: not llvm-mc -triple aarch64-none-linux-gnu < %s 2> %t
// RUN: FileCheck --check-prefix=CHECK-ERR --check-prefix=CHECK-NO-LS64-ERR %s < %t // RUN: FileCheck --check-prefixes=CHECK-ERR,CHECK-NO-LS64-ERR %s < %t
ld64b x0, [x13] ld64b x0, [x13]
st64b x14, [x13] st64b x14, [x13]
st64bv x1, x20, [x13] st64bv x1, x20, [x13]
st64bv0 x1, x22, [x13] st64bv0 x1, x22, [x13]
// CHECK: ld64b x0, [x13] // encoding: [0xa0,0xd1,0x3f,0xf8] // CHECK: ld64b x0, [x13] // encoding: [0xa0,0xd1,0x3f,0xf8]
// CHECK: st64b x14, [x13] // encoding: [0xae,0x91,0x3f,0xf8] // CHECK: st64b x14, [x13] // encoding: [0xae,0x91,0x3f,0xf8]
// CHECK: st64bv x1, x20, [x13] // encoding: [0xb4,0xb1,0x21,0xf8] // CHECK: st64bv x1, x20, [x13] // encoding: [0xb4,0xb1,0x21,0xf8]
Show All 26 Lines

llvm/test/MC/AArch64/armv8.7a-xs.s

// RUN: not llvm-mc -triple aarch64-none-linux-gnu -show-encoding -mattr=+v8.4a,+xs < %s 2>%t | FileCheck %s // RUN: not llvm-mc -triple aarch64-none-linux-gnu -show-encoding -mattr=+v8.4a,+xs < %s 2>%t | FileCheck %s
// RUN: FileCheck --check-prefix=CHECK-ERR --check-prefix=CHECK-XS-ERR %s < %t // RUN: FileCheck --check-prefix=CHECK-ERR %s < %t
// RUN: not llvm-mc -triple aarch64-none-linux-gnu -show-encoding -mattr=+v8.7a < %s 2>%t | FileCheck %s // RUN: not llvm-mc -triple aarch64-none-linux-gnu -show-encoding -mattr=+v8.7a < %s 2>%t | FileCheck %s
// RUN: FileCheck --check-prefix=CHECK-ERR --check-prefix=CHECK-XS-ERR %s < %t // RUN: FileCheck --check-prefix=CHECK-ERR %s < %t
// RUN: not llvm-mc -triple aarch64-none-linux-gnu -mattr=+v8.4a < %s 2> %t // RUN: not llvm-mc -triple aarch64-none-linux-gnu -mattr=+v8.4a < %s 2> %t
// RUN: FileCheck --check-prefix=CHECK-ERR --check-prefix=CHECK-NO-XS-ERR %s < %t // RUN: FileCheck --check-prefixes=CHECK-ERR,CHECK-NO-XS-ERR %s < %t
dsb #16 dsb #16
dsb #20 dsb #20
dsb #24 dsb #24
dsb #28 dsb #28
dsb oshnxs dsb oshnxs
dsb nshnxs dsb nshnxs
dsb ishnxs dsb ishnxs
▲ Show 20 Lines • Show All 259 Lines • Show Last 20 Lines

llvm/test/MC/AArch64/lit.local.cfg

from lit.llvm.subst import ToolSubst
if 'AArch64' not in config.root.targets: if 'AArch64' not in config.root.targets:
config.unsupported = True config.unsupported = True
fc = ToolSubst('FileCheck', unresolved='fatal')
# Insert this first. Then, we'll first update the blank FileCheck command; then,
# the default substitution of FileCheck will replace it to its full path.
config.substitutions.insert(0, (fc.regex,
'FileCheck --allow-unused-prefixes=false'))