Page MenuHomePhabricator

[libc++] Rename check-cxx-deps to cxx-test-depends for consistency
ClosedPublic

Authored by ldionne on Jan 12 2021, 7:59 AM.

Details

Summary

Several subprojects have targets that do the same thing, and they all
follow the same naming convention: llvm-test-depends, clang-test-depends,
lld-test-depends, etc.

This makes libc++ consistent with other LLVM projects.
Thanks to Duncan Exon Smith for noticing and suggesting the change.

Diff Detail

Event Timeline

ldionne created this revision.Jan 12 2021, 7:59 AM
ldionne requested review of this revision.Jan 12 2021, 7:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2021, 7:59 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
dexonsmith accepted this revision.Jan 12 2021, 10:05 AM

LGTM!

Can / should this be added to the catch-all test-depends as well? (I thought llvm-test-depends and clang-test-depends were both added there somewhere, although I admit I just the code and I don't see it...) Regardless, this could be done separately / later if it makes sense to do.

LGTM!

Can / should this be added to the catch-all test-depends as well? (I thought llvm-test-depends and clang-test-depends were both added there somewhere, although I admit I just the code and I don't see it...) Regardless, this could be done separately / later if it makes sense to do.

My preference would be not to do that. The reason is that we want to have different build requirements for libc++ and Clang or LLVM. For example, we want to move towards requiring a more recent compiler. Running the libc++ build (and/or tests) by default when setting up LLVM would make that more difficult.

ldionne accepted this revision as: Restricted Project.Jan 18 2021, 11:41 AM
This revision is now accepted and ready to land.Jan 18 2021, 11:41 AM