Page MenuHomePhabricator

[clang][cli] Port more CodeGenOptions to marshalling infrastructure
ClosedPublic

Authored by jansvoboda11 on Jan 12 2021, 3:36 AM.

Details

Summary

Leveraging the recently added marshalling constructs.

Diff Detail

Event Timeline

jansvoboda11 created this revision.Jan 12 2021, 3:36 AM
jansvoboda11 requested review of this revision.Jan 12 2021, 3:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2021, 3:36 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
jansvoboda11 added inline comments.Jan 12 2021, 3:39 AM
clang/include/clang/Driver/Options.td
1168

The profile_arcs and test_coverage options were moved here so that fprofile_filter_files_EQ and fprofile_exclude_files_EQ can refer to their keypaths.

clang/lib/Frontend/CompilerInvocation.cpp
1144–1145

This piece of code should've been removed in D84669 which added marshalling info to stack_protector_buffer_size.

dexonsmith accepted this revision.Jan 12 2021, 10:21 AM

LGTM, with one nit. It'd be nice to add more detail to the commit message as well.

clang/lib/Frontend/CompilerInvocation.cpp
1144–1145

In that case please commit this separately. Since I presume it's NFC and pretty straightforward, likely you don't need a separate review, but please make sure the commit message is good / refers to what made it NFC / etc..

This revision is now accepted and ready to land.Jan 12 2021, 10:21 AM

Thanks for taking a look! Committed with more detailed message.

clang/lib/Frontend/CompilerInvocation.cpp
1144–1145