Page MenuHomePhabricator

[libc++] NFC: Document the Differential queries to avoid duplicating work
ClosedPublic

Authored by ldionne on Jan 8 2021, 2:23 PM.

Diff Detail

Event Timeline

ldionne created this revision.Jan 8 2021, 2:23 PM
ldionne requested review of this revision.Jan 8 2021, 2:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 8 2021, 2:23 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript

@Fabio Here it is. Hopefully this should prevent situations like the .contains one in the future.

@griwes @wash You were once asking for how to look for open reviews, well the queries are now public!

zoecarver accepted this revision.Jan 8 2021, 2:28 PM
zoecarver added a subscriber: zoecarver.

@ldionne thank you for adding this much-needed bit of documentation.

I don't think you need to add this to the docs, but just so people know, you can also search reviews.llvm.org.

@ldionne thank you for adding this much-needed bit of documentation.

Indeed. I always feel sorry for people who spend valuable time working on something, and then we have to tell them "it's already been done". It's not acceptable for an open source project IMO.

The problem is that we did *not* have these queries 30 minutes ago. I needed admin rights to add them, and had been waiting to get them. Fortunately, I got help from the right people just now. Yay!

ldionne accepted this revision.Jan 8 2021, 2:47 PM

Opened a review mostly so people would know about the query. Shipping!

This revision is now accepted and ready to land.Jan 8 2021, 2:47 PM
This revision was landed with ongoing or failed builds.Jan 8 2021, 2:48 PM
This revision was automatically updated to reflect the committed changes.