User Details
User Details
- User Since
- Dec 19 2018, 10:26 AM (249 w, 6 d)
Dec 11 2020
Dec 11 2020
griwes added a comment to D89057: Add the C++17 <memory_resource> header (mono-patch).
So far, I've left initial_header alone, even though technically it is neither a header nor a footer, because it is stored outside of the initial buffer. Perhaps it could be renamed something like initial_info? Any thoughts on terminology there, @griwes?
Nov 19 2020
Nov 19 2020
This all definitely feels extremely familiar - this is essentially the same code I've written for thrust::mr, minus the semantic extensions we've done and some code organization differences. I've left few minor comments below, but otherwise this looks good, with two additional top level comments that should be resolved before this is merged:
Jun 4 2020
Jun 4 2020
griwes added a comment to D81190: [libc++] Link against libatomic when it is found.
FWIW this looks good to me as well.
Jun 4 2020, 2:57 PM · Restricted Project
Oct 16 2019
Oct 16 2019
griwes added inline comments to D68480: Implementation of C++20's P1135R6 for libcxx.