This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Fix incorrect rpath for tests if LLVM_LOCAL_RPATH isn't set
ClosedPublic

Authored by tambre on Jan 8 2021, 11:24 AM.

Details

Summary

d9ce31ae7d (D94322) removed the check because I thought it was dead
due to checking the existance of a variable (which always existed).

This causes LLDB tests to fail as they set NO_INSTALL_RPATH because
they're never meant to be installed, but we still would end up using
the install rpath.

Add the check back and make it explicitly check for an empty value
to make the purpose clearer and avoid implicit test for a false/true
value.

Diff Detail

Event Timeline

tambre created this revision.Jan 8 2021, 11:24 AM
tambre requested review of this revision.Jan 8 2021, 11:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 8 2021, 11:24 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 8 2021, 11:24 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.