Page MenuHomePhabricator

[libcxx] Port to OpenBSD
ClosedPublic

Authored by brad on Jan 6 2021, 4:49 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG79f99ba65d96: [libcxx] Port to OpenBSD
Summary

A patch to add initial OpenBSD support.

Diff Detail

Event Timeline

brad requested review of this revision.Jan 6 2021, 4:49 PM
brad created this revision.
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptJan 6 2021, 4:49 PM
ldionne accepted this revision.Jan 12 2021, 10:41 AM

Sorry, I think I had started the review on my phone and forgot to pick it back up. LGTM, do you need commit access?

On a side note, everybody porting to a new platform needs to add this xlocale.h header. I think it points to something we could improve on.

libcxx/include/__config
373

OpenBSD doesn’t have quick exit?

This revision is now accepted and ready to land.Jan 12 2021, 10:41 AM
brad added a comment.Jan 12 2021, 11:01 AM

Sorry, I think I had started the review on my phone and forgot to pick it back up. LGTM, do you need commit access?

Thanks. I wasn't sure if you saw this since Phabricator had a warning about something being blocked. I didn't fully understand that part.

I have commit access.

libcxx/include/__config
373

OpenBSD doesn’t have quick exit?

Correct. I am prodding from our end to see about such support being added especially seeing as we're the odd man out.

This revision was automatically updated to reflect the committed changes.