This is an archive of the discontinued LLVM Phabricator instance.

[OpenCL] Documentation for experimental C++ libraries support
ClosedPublic

Authored by Anastasia on Jan 6 2021, 12:41 PM.

Details

Summary

Started a new doc section about the OpenCL experimental features and described ongoing work on C++ libraries e.g. type traits.

Diff Detail

Event Timeline

Anastasia created this revision.Jan 6 2021, 12:41 PM
Anastasia requested review of this revision.Jan 6 2021, 12:41 PM
Anastasia retitled this revision from [OpenCL] add documentation for experimental C++ libraries support to [OpenCL] Documentation for experimental C++ libraries support.Jan 6 2021, 12:51 PM

This patch is uploaded on top of https://reviews.llvm.org/D93942

Looks good overall.

clang/docs/OpenCLSupport.rst
104

Remove "with".

115

s/use/include/

116

s/if/when/

134

I'd use < and > instead of ". It should work too, right? It would be closer to standard C++ usage.

138

Two things:

  • identifier ending with _t are reserved for the compiler I believe.
  • to show usage of modern C++, this could be rewritten into using sint = std::....
151

s/for/against/

Anastasia updated this revision to Diff 315173.Jan 7 2021, 10:09 AM

Addressed review comments

Anastasia marked 6 inline comments as done.Jan 7 2021, 10:11 AM
Anastasia added inline comments.
clang/docs/OpenCLSupport.rst
134

Yes it does work. I was only thinking to use " to highlight that it is not standard in OpenCL but it doesn't matter too much. I guess it makes sense to align with C++.

This revision is now accepted and ready to land.Jan 8 2021, 1:17 AM
This revision was automatically updated to reflect the committed changes.
Anastasia marked an inline comment as done.
Herald added a project: Restricted Project. · View Herald TranscriptJan 8 2021, 5:46 AM