This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Remove wrapper only call limitation
ClosedPublic

Authored by arsenm on Jan 6 2021, 12:27 PM.

Details

Reviewers
rampitec
aeubanks
Summary

This seems to only have overridden cold handling, which we probably
shouldn't do. As far as I can tell the wrapper library functions are still inlined as appropriate.

Diff Detail

Event Timeline

arsenm created this revision.Jan 6 2021, 12:27 PM
arsenm requested review of this revision.Jan 6 2021, 12:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 6 2021, 12:27 PM
Herald added a subscriber: wdng. · View Herald Transcript
aeubanks accepted this revision.Jan 6 2021, 12:35 PM

I suppose doing some benchmarking would be ideal, but this makes sense, I can't imagine why these sorts of functions wouldn't be inlined other than attributes like coldcc/noinline.

This revision is now accepted and ready to land.Jan 6 2021, 12:35 PM

is this good to go?