Page MenuHomePhabricator

[lldb-vscode] improve modules request
ClosedPublic

Authored by wallace on Jan 4 2021, 2:13 PM.

Details

Summary

lldb-vscode was communicating the list of modules to the IDE with events, which in practice ended up having some drawbacks

  • when debugging large targets, the number of these events were easily 10k, which polluted the messages being transmitted, which caused the following: a harder time debugging the messages, a lag after terminated the process because of these messages being processes (this could easily take a few seconds). The latter was specially bad, as users were complaining about it even when they didn't check the modules view.
  • these events were rarely used, as users only check the modules view when something is wrong and they try to debug things.

After getting some feedback from users, we realized that it's better to not used events but make this simply a request and is triggered by users whenever they needed.

This diff achieves that and does some small clean up in the existing code.

Diff Detail

Event Timeline

wallace requested review of this revision.Jan 4 2021, 2:13 PM
wallace created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 4 2021, 2:13 PM
wallace edited the summary of this revision. (Show Details)Jan 4 2021, 2:24 PM
clayborg accepted this revision.Jan 4 2021, 3:04 PM

LGTM

This revision is now accepted and ready to land.Jan 4 2021, 3:04 PM
This revision was landed with ongoing or failed builds.Jan 21 2021, 1:19 PM
This revision was automatically updated to reflect the committed changes.