Page MenuHomePhabricator

[mlir] Fix indexing of first offset operand in ops that implement OffsetSizeAndStrideOpInterface
ClosedPublic

Authored by nicolasvasilache on Dec 30 2020, 8:44 AM.

Details

Summary

OffsetSizeAndStrideOpInterface ops may have a varying number of operands before the first
offset operand. This revision adds a method that such ops much implement to properly specify
the position of the first offset operand.

Diff Detail

Event Timeline

nicolasvasilache requested review of this revision.Dec 30 2020, 8:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 30 2020, 8:44 AM
pifon2a accepted this revision.Dec 30 2020, 8:50 AM
This revision is now accepted and ready to land.Dec 30 2020, 8:50 AM
This revision was landed with ongoing or failed builds.Dec 30 2020, 8:57 AM
This revision was automatically updated to reflect the committed changes.

Missing a test case?

mlir/include/mlir/Interfaces/ViewLikeInterface.td
44

Nit: missing period at the end.