This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Enhance mlir-opt show-dialects test case
ClosedPublic

Authored by Lewuathe on Dec 26 2020, 4:43 AM.

Download Raw Diff

Details

Reviewers

aartbik
stephenneuendorffer
mehdi_amini

Commits

rG03d249396d6b: [mlir] Enhance mlir-opt show-dialects test case

Summary

mlir-opt supports many more test cases. All available dialects supported by latest mlir-opt should be coverted in the test case.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

Lewuathe created this revision.Dec 26 2020, 4:43 AM

Herald added a reviewer: aartbik. · View Herald TranscriptDec 26 2020, 4:43 AM

Herald added subscribers: teijeong, rdzhabarov, tatianashp and 14 others. · View Herald Transcript

Lewuathe requested review of this revision.Dec 26 2020, 4:43 AM

Herald added a project: Restricted Project. · View Herald TranscriptDec 26 2020, 4:43 AM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

Lewuathe retitled this revision from Enhance mlir-opt show-dialects test case to [mlir] Enhance mlir-opt show-dialects test case.Dec 26 2020, 4:45 AM

Lewuathe edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B83511: Diff 313743.Dec 26 2020, 5:04 AM

aartbik accepted this revision.Jan 5 2021, 9:58 AM

This revision is now accepted and ready to land.Jan 5 2021, 9:58 AM

Great!

mehdi_amini added inline comments.Jan 5 2021, 11:33 AM

mlir/test/mlir-opt/commandline.mlir
3–29	If we want this list to stay up-to-date, we should use CHECK-NEXT everywhere.

Lewuathe added inline comments.Jan 7 2021, 4:55 PM

mlir/test/mlir-opt/commandline.mlir
3–29	@mehdi_amini Thank you! That's a good idea. I'll update the patch.

Use CHECK-NEXT

Harbormaster completed remote builds in B84413: Diff 315283.Jan 7 2021, 6:41 PM

Still LGTM! Do you have commit access or do you need someone to land it for you?

@mehdi_amini I do not have write access. Could you do that on behalf of me? Thank you!

Closed by commit rG03d249396d6b: [mlir] Enhance mlir-opt show-dialects test case (authored by Lewuathe, committed by mehdi_amini). · Explain WhyJan 9 2021, 12:44 PM

This revision was automatically updated to reflect the committed changes.

mehdi_amini added a commit: rG03d249396d6b: [mlir] Enhance mlir-opt show-dialects test case.

Revision Contents

Path

Size

mlir/

test/

mlir-opt/

commandline.mlir

41 lines

Diff 315630

mlir/test/mlir-opt/commandline.mlir

	// RUN: mlir-opt --show-dialects \| FileCheck %s			// RUN: mlir-opt --show-dialects \| FileCheck %s
	// CHECK: Available Dialects:			// CHECK: Available Dialects:
	// CHECK: affine			// CHECK-NEXT: acc
	// CHECK: gpu			// CHECK-NEXT: affine
	// CHECK: linalg			// CHECK-NEXT: arm_neon
	// CHECK: llvm			// CHECK-NEXT: arm_sve
	// CHECK: nvvm			// CHECK-NEXT: async
	// CHECK: omp			// CHECK-NEXT: avx512
	// CHECK: quant			// CHECK-NEXT: gpu
	// CHECK: rocdl			// CHECK-NEXT: linalg
	// CHECK: scf			// CHECK-NEXT: llvm
	// CHECK: sdbm			// CHECK-NEXT: llvm_arm_neon
	// CHECK: spv			// CHECK-NEXT: llvm_arm_sve
	// CHECK: std			// CHECK-NEXT: llvm_avx512
	// CHECK: test			// CHECK-NEXT: nvvm
	// CHECK: vector			// CHECK-NEXT: omp
				// CHECK-NEXT: pdl
				// CHECK-NEXT: pdl_interp
				// CHECK-NEXT: quant
				// CHECK-NEXT: rocdl
				// CHECK-NEXT: scf
				// CHECK-NEXT: sdbm
				// CHECK-NEXT: shape
				// CHECK-NEXT: spv
				// CHECK-NEXT: std
				// CHECK-NEXT: tensor
				// CHECK-NEXT: test
				// CHECK-NEXT: tosa
				// CHECK-NEXT: vector
				mehdi_aminiUnsubmitted Not Done Reply Inline Actions If we want this list to stay up-to-date, we should use CHECK-NEXT everywhere. mehdi_amini: If we want this list to stay up-to-date, we should use CHECK-NEXT everywhere.
				LewuatheAuthorUnsubmitted Done Reply Inline Actions @mehdi_amini Thank you! That's a good idea. I'll update the patch. Lewuathe: @mehdi_amini Thank you! That's a good idea. I'll update the patch.