[mlir] NFC: Remove ConvertToLLVMPattern::getDataPtr(). All call sites use getStridedElementPtr() now.

[ftynse]

Thanks for cleanup!

mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVM.h

Value createIndexConstant(ConversionPatternRewriter &builder, Location loc,
                             uint64_t value) const;
 
   // This is a strided getElementPtr variant that linearizes subscripts as:
   //   `base_offset + index_0 * stride_0 + ... + index_n * stride_n`.
   Value getStridedElementPtr(Location loc, MemRefType type, Value memRefDesc,
                              ValueRange indices,
                              ConversionPatternRewriter &rewriter) const;
 
-  // Forwards to getStridedElementPtr. TODO: remove.
-  Value getDataPtr(Location loc, MemRefType type, Value memRefDesc,
-                   ValueRange indices,
-                   ConversionPatternRewriter &rewriter) const;
-
   /// Returns if the givem memref type is supported.
   bool isSupportedMemRefType(MemRefType type) const;
 
   /// Returns the type of a pointer to an element of the memref.
   Type getElementPtrType(MemRefType type) const;
 
   /// Computes sizes, strides and buffer size in bytes of `memRefType` with
   /// identity layout. Emits constant ops for the static sizes of `memRefType`,

mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp

index =
         index ? rewriter.create<LLVM::AddOp>(loc, index, increment) : increment;
   }
 
   LLVM::LLVMType elementPtrType = memRefDescriptor.getElementPtrType();
   return index ? rewriter.create<LLVM::GEPOp>(loc, elementPtrType, base, index)
                : base;
 }
 
-Value ConvertToLLVMPattern::getDataPtr(
-    Location loc, MemRefType type, Value memRefDesc, ValueRange indices,
-    ConversionPatternRewriter &rewriter) const {
-  return getStridedElementPtr(loc, type, memRefDesc, indices, rewriter);
-}
-
 // Check if the MemRefType `type` is supported by the lowering. We currently
 // only support memrefs with identity maps.
 bool ConvertToLLVMPattern::isSupportedMemRefType(MemRefType type) const {
   if (!typeConverter->convertType(type.getElementType()))
     return false;
   return type.getAffineMaps().empty() ||
          llvm::all_of(type.getAffineMaps(),
                       [](AffineMap map) { return map.isIdentity(); });