This is an archive of the discontinued LLVM Phabricator instance.

Updating macOS Version logic for macOS 11+ and Darwin 20+
AbandonedPublic

Authored by AndrewLitteken on Dec 17 2020, 10:52 AM.

Details

Reviewers
arphaman
Group Reviewers
Restricted Project
Summary

Minor releases of macOS 11+ increment the minor field rather than the micro field at the same rate as the Darwin minor field. Currently the getMacOSHostVersion test fails for macOS 11.1.

This adjusts the logic for the found macOS minor version from the Darwin version to be one less than the Darwin minor version unless the Darwin minor version, is zero, in which case the macOS minor version is also zero. This is a guess based on the past few releases: https://en.wikipedia.org/wiki/Darwin_(operating_system).

Diff Detail

Event Timeline

AndrewLitteken requested review of this revision.Dec 17 2020, 10:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 17 2020, 10:52 AM
AndrewLitteken abandoned this revision.Jan 28 2022, 1:10 PM

Closing since has been solved differently