This is an archive of the discontinued LLVM Phabricator instance.

[libomptarget][nfc] Replace static const with enum
ClosedPublic

Authored by JonChesterfield on Dec 15 2020, 12:04 PM.

Details

Summary

[libomptarget][nfc] Replace static const with enum

Semantically identical. Replaces 0xff... with ~0 to spare counting the f.
Has the advantage that the compiler doesn't need to prove the 4/8 byte
value dead before discarding it, and sidesteps the compilation question
associated with what static means for a single source language.

Diff Detail

Event Timeline

JonChesterfield requested review of this revision.Dec 15 2020, 12:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 15 2020, 12:04 PM
This revision is now accepted and ready to land.Dec 15 2020, 12:12 PM
This revision was landed with ongoing or failed builds.Dec 16 2020, 8:40 AM
This revision was automatically updated to reflect the committed changes.