This is an archive of the discontinued LLVM Phabricator instance.

Add section page for Rationale docs.
ClosedPublic

Authored by richard-uhler on Dec 14 2020, 2:11 PM.

Details

Summary

With a brief overview and summary of each of the Rationale docs.

Diff Detail

Event Timeline

richard-uhler created this revision.Dec 14 2020, 2:11 PM
richard-uhler requested review of this revision.Dec 14 2020, 2:11 PM
rriddle accepted this revision.Dec 14 2020, 2:13 PM

Thanks!

mlir/docs/Rationale/_index.md
7

Would the - description work better as a sub bullet? How is this displayed on the website?

This revision is now accepted and ready to land.Dec 14 2020, 2:13 PM
jpienaar accepted this revision.Dec 14 2020, 2:22 PM
jpienaar added a subscriber: jpienaar.

Thanks

mlir/docs/Rationale/_index.md
30

Nit (and this could be in doc too/not due to you) but s/'Const'/'const'/ given C keyword

Switch to using markdown's definition list.

Switch from Const to const.

richard-uhler marked an inline comment as done.Dec 14 2020, 2:35 PM
richard-uhler added inline comments.
mlir/docs/Rationale/_index.md
7

I tried some variations. I like definition list best, so I switched to that. Screenshot attached:

.

rriddle added inline comments.Dec 14 2020, 2:38 PM
mlir/docs/Rationale/_index.md
7

LG, thanks.

This revision was landed with ongoing or failed builds.Dec 14 2020, 2:49 PM
This revision was automatically updated to reflect the committed changes.