This is an archive of the discontinued LLVM Phabricator instance.

Differential D93244

Remove the ast_type_traits namespace.
ClosedPublic

Authored by alexfh on Dec 14 2020, 2:09 PM.

Details

Reviewers
aaron.ballman
rnk
steveire
Commits
rG9c49b0bba0fc: Remove the ast_type_traits namespace.
Summary

This is the final cleanup after https://reviews.llvm.org/D74499

Diff Detail

Unit TestsFailed

TimeTest
120 msx64 debian > Clang.CodeGen::thinlto-distributed-newpm.ll
360 msx64 windows > Clang.CodeGen::thinlto-distributed-newpm.ll
90 msx64 windows > LLVM.CodeGen/XCore::threads.ll

Event Timeline

alexfh requested review of this revision.Dec 14 2020, 2:09 PM
alexfh created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 14 2020, 2:09 PM
steveire accepted this revision.Dec 14 2020, 2:16 PM
steveire added a subscriber: steveire.

LGTM

This revision is now accepted and ready to land.Dec 14 2020, 2:16 PM
Harbormaster completed remote builds in B82337: Diff 311702.Dec 14 2020, 3:26 PM
This revision was landed with ongoing or failed builds.Dec 14 2020, 5:16 PM
Closed by commit rG9c49b0bba0fc: Remove the ast_type_traits namespace. (authored by alexfh). · Explain Why
This revision was automatically updated to reflect the committed changes.
alexfh added a commit: rG9c49b0bba0fc: Remove the ast_type_traits namespace..

Revision Contents

PathSize
clang/
include/
clang/
AST/
12 lines

Diff 311702

clang/include/clang/AST/ASTTypeTraits.h

Show First 20 Lines • Show All 522 Lines • ▼ Show 20 Lines
// AST node that is not supported, but prevents misuse - a user cannot create // AST node that is not supported, but prevents misuse - a user cannot create
// a DynTypedNode from arbitrary types. // a DynTypedNode from arbitrary types.
template <typename T, typename EnablerT> struct DynTypedNode::BaseConverter { template <typename T, typename EnablerT> struct DynTypedNode::BaseConverter {
static const T *get(ASTNodeKind NodeKind, const char Storage[]) { static const T *get(ASTNodeKind NodeKind, const char Storage[]) {
return NULL; return NULL;
} }
}; };
// Previously these types were defined in the clang::ast_type_traits namespace.
// Provide typedefs so that legacy code can be fixed asynchronously.
namespace ast_type_traits {
using DynTypedNode = ::clang::DynTypedNode;
using ASTNodeKind = ::clang::ASTNodeKind;
using TraversalKind = ::clang::TraversalKind;
constexpr TraversalKind TK_AsIs = ::clang::TK_AsIs;
constexpr TraversalKind TK_IgnoreUnlessSpelledInSource =
::clang::TK_IgnoreUnlessSpelledInSource;
} // namespace ast_type_traits
} // end namespace clang } // end namespace clang
namespace llvm { namespace llvm {
template <> template <>
struct DenseMapInfo<clang::ASTNodeKind> : clang::ASTNodeKind::DenseMapInfo {}; struct DenseMapInfo<clang::ASTNodeKind> : clang::ASTNodeKind::DenseMapInfo {};
template <> template <>
struct DenseMapInfo<clang::DynTypedNode> : clang::DynTypedNode::DenseMapInfo {}; struct DenseMapInfo<clang::DynTypedNode> : clang::DynTypedNode::DenseMapInfo {};
} // end namespace llvm } // end namespace llvm
#endif #endif