This is an archive of the discontinued LLVM Phabricator instance.

Differential D93155

[test-suite] 7zip CMake fix.
ClosedPublic

Authored by naromero77 on Dec 11 2020, 10:07 PM.

Details

Reviewers
MatzeB
t.p.northover
arichardson
Meinersbur
Summary

Use clang alias for narrowing flag so that it is recognized by the GCC compiler

Diff Detail

Event Timeline

naromero77 created this revision.Dec 11 2020, 10:07 PM
Herald added a subscriber: mgorny. · View Herald TranscriptDec 11 2020, 10:07 PM
naromero77 requested review of this revision.Dec 11 2020, 10:07 PM
Harbormaster completed remote builds in B82134: Diff 311364.Dec 11 2020, 10:07 PM
naromero77 added a subscriber: llvm-commits.Dec 11 2020, 10:09 PM
naromero77 added reviewers: MatzeB, t.p.northover, arichardson, Meinersbur.Dec 11 2020, 10:13 PM
Meinersbur accepted this revision.Dec 14 2020, 8:04 AM
Meinersbur retitled this revision from 7zip CMake fix to [test-suite] 7zip CMake fix..
Meinersbur edited the summary of this revision. (Show Details)

LGTM

This revision is now accepted and ready to land.Dec 14 2020, 8:05 AM
naromero77 added a comment.Dec 16 2020, 9:23 PM

Committed as https://github.com/llvm/llvm-test-suite/commit/b2fbd488cb0135f68422740e19eff9eff4c5a7f0

naromero77 closed this revision.Dec 16 2020, 9:23 PM

Revision Contents

PathSize
MultiSource/
Benchmarks/
7zip/
2 lines

Diff 311364

MultiSource/Benchmarks/7zip/CMakeLists.txt

set(RUN_OPTIONS b) set(RUN_OPTIONS b)
list(APPEND CFLAGS -DBREAK_HANDLER -DUNICODE -D_UNICODE -I${CMAKE_CURRENT_SOURCE_DIR}/C -I${CMAKE_CURRENT_SOURCE_DIR}/CPP/myWindows -I${CMAKE_CURRENT_SOURCE_DIR}/CPP/include_windows -I${CMAKE_CURRENT_SOURCE_DIR}/CPP -I. -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DNDEBUG -D_REENTRANT -DENV_UNIX -D_7ZIP_LARGE_PAGES -pthread) list(APPEND CFLAGS -DBREAK_HANDLER -DUNICODE -D_UNICODE -I${CMAKE_CURRENT_SOURCE_DIR}/C -I${CMAKE_CURRENT_SOURCE_DIR}/CPP/myWindows -I${CMAKE_CURRENT_SOURCE_DIR}/CPP/include_windows -I${CMAKE_CURRENT_SOURCE_DIR}/CPP -I. -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DNDEBUG -D_REENTRANT -DENV_UNIX -D_7ZIP_LARGE_PAGES -pthread)
list(APPEND CXXFLAGS -Wno-error=c++11-narrowing -DBREAK_HANDLER -DUNICODE -D_UNICODE -I${CMAKE_CURRENT_SOURCE_DIR}/C -I${CMAKE_CURRENT_SOURCE_DIR}/CPP/myWindows -I${CMAKE_CURRENT_SOURCE_DIR}/CPP/include_windows -I${CMAKE_CURRENT_SOURCE_DIR}/CPP -I. -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DNDEBUG -D_REENTRANT -DENV_UNIX -D_7ZIP_LARGE_PAGES -pthread) list(APPEND CXXFLAGS -Wno-error=narrowing -DBREAK_HANDLER -DUNICODE -D_UNICODE -I${CMAKE_CURRENT_SOURCE_DIR}/C -I${CMAKE_CURRENT_SOURCE_DIR}/CPP/myWindows -I${CMAKE_CURRENT_SOURCE_DIR}/CPP/include_windows -I${CMAKE_CURRENT_SOURCE_DIR}/CPP -I. -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DNDEBUG -D_REENTRANT -DENV_UNIX -D_7ZIP_LARGE_PAGES -pthread)
list(APPEND LDFLAGS -pthread) list(APPEND LDFLAGS -pthread)
set(NO_REFERENCE_OUTPUT 1) set(NO_REFERENCE_OUTPUT 1)
llvm_multisource(7zip-benchmark llvm_multisource(7zip-benchmark
CPP/myWindows/myGetTickCount.cpp CPP/myWindows/myGetTickCount.cpp
CPP/myWindows/wine_date_and_time.cpp CPP/myWindows/wine_date_and_time.cpp
CPP/myWindows/myAddExeFlag.cpp CPP/myWindows/myAddExeFlag.cpp
CPP/myWindows/mySplitCommandLine.cpp CPP/myWindows/mySplitCommandLine.cpp
CPP/7zip/UI/Console/BenchCon.cpp CPP/7zip/UI/Console/BenchCon.cpp
▲ Show 20 Lines • Show All 208 Lines • Show Last 20 Lines