[test-suite] ClamAV CMake fix.

[naromero77]

Summary

CMake needs help finding gettext libintl libraries in environments with non-standard GCC installs.

[Meinersbur]

Usually system introspection happens in the top-level CMakeLists.txt, but test-suite allows to selectively include subdirs, so it is a good location to do here.

If ClamAV is using gettext only, maybe use FindGettext instead?

MultiSource/Applications/ClamAV/CMakeLists.txt

173

Please use find_package (also see https://cmake.org/cmake/help/latest/manual/cmake-modules.7.html#find-modules)

[naromero77]

The CMake documentation says to use FindIntl for the gettext libintl libraries
https://cmake.org/cmake/help/latest/module/FindIntl.html#module:FindIntl

but use FindGettext for tools (msmerge, msgfmt, etc.).

ClamAV is only using the former.

[Meinersbur]

You are right, FindGettext seems to look for some commands, not the library.

Can you still do the find_package change?

MultiSource/Applications/ClamAV/CMakeLists.txt

173

[naromero77]

• Use find_package instead.

[Meinersbur]

LGTM

[naromero77]

Committed as https://github.com/llvm/llvm-test-suite/commit/cbcc0f45e76a704e9796c973ee770dceec9067f4

[aemerson]

This seems to have caused failures on Darwin platforms. I've pushed a fix in 48e7b34f but let me know if you disagree with the approach.

[Meinersbur]

I would have done an unequal: if (NOT TARGET_OS STREQUAL "Darwin"). libIntl is part of the GNU user space environment, not the kernel, e.g. also apply to GNU/kFreeBSD.

More generally, IMHO cmake should have abstracted over this, for platforms that don't need libIntl.

MultiSource/Applications/ClamAV/CMakeLists.txt

llvm_multisource(clamscan
   zlib_infback.c
   zlib_inffast.c
   zlib_inflate.c
   zlib_inftrees.c
   zlib_trees.c
   zlib_uncompr.c
   zlib_zutil.c
 )
+find_package(Intl REQUIRED)
+target_link_libraries(clamscan ${Intl_LIBRARIES})
 llvm_test_data(clamscan ${INPUT} dbdir)