This is an archive of the discontinued LLVM Phabricator instance.

[VE] Optimize toolchain regression test
ClosedPublic

Authored by kaz7 on Dec 10 2020, 8:08 PM.

Details

Summary

Optimize toolchain regression test for VE by removing not a useful test
(-fuse-init-array test) and merge several tests to one test which checks
default behavior of driver. Also add sysroot to reduce conflicts.

These are suggested in https://reviews.llvm.org/D92996.
Thank you so much.

Diff Detail

Event Timeline

kaz7 created this revision.Dec 10 2020, 8:08 PM
kaz7 requested review of this revision.Dec 10 2020, 8:08 PM

LG.

I don't have a system VE toolchain and the tests still pass.

MaskRay added inline comments.Dec 11 2020, 9:41 AM
clang/test/Driver/ve-toolchain.cpp
124

You probably should add an empty file in basic_ve_tree so that users who don't have a system ve toolchain (most upstream developers) have "...basic_ve_tree/...crtbegin.o" instead of "crtbegin.o"

kaz7 added a comment.Dec 12 2020, 5:32 PM

Thank you for suggestions.

clang/test/Driver/ve-toolchain.cpp
124

Thank you for remainding it. I've forgotten them. We use crtbegin.o from compiler-rt, so I will add empty files to RESOURCE_DIR also.

kaz7 updated this revision to Diff 311423.Dec 12 2020, 6:25 PM

Rebase and update following suggestions. Thanks!

MaskRay accepted this revision.Dec 12 2020, 7:45 PM

Thanks. The tests still work fine on my machine.

This revision is now accepted and ready to land.Dec 12 2020, 7:45 PM
This revision was landed with ongoing or failed builds.Dec 13 2020, 3:26 AM
This revision was automatically updated to reflect the committed changes.
kaz7 added a comment.Dec 13 2020, 3:40 AM

Thank you so much too. I could learn how to write better clang tests. :-)