Page MenuHomePhabricator

[mlir][docs] Tidy up the pass infrastructure documentation
ClosedPublic

Authored by rriddle on Dec 10 2020, 6:53 PM.

Details

Summary

The doc has grown stale and is missing some recent changes to the infrastructure.

Diff Detail

Event Timeline

rriddle created this revision.Dec 10 2020, 6:53 PM
rriddle requested review of this revision.Dec 10 2020, 6:53 PM
mehdi_amini added inline comments.Dec 10 2020, 7:27 PM
mlir/docs/PassManagement.md
43

This last point is lost?

520–521

I'd say first that "registering passes allows to parse a textual pipeline description" (and then mention that it is useful for utilities like mlir-opt)

rriddle updated this revision to Diff 311326.Dec 11 2020, 2:54 PM
rriddle marked an inline comment as done.

Update

rriddle marked an inline comment as done.Dec 11 2020, 2:55 PM
rriddle added inline comments.
mlir/docs/PassManagement.md
43

I felt that this point was just a restatement of the second bullet:

Modify the state of another operation not nested within the current
    operation being operated on.
520–521

Thanks. Tried to reword a bit to put less emphasis on command line, and more on the textual format in general.

mehdi_amini added inline comments.Dec 11 2020, 4:09 PM
mlir/docs/PassManagement.md
43

I see a difference though, the point you're referring to is about *modifying* the state of another operation, but it does not say anything about *inspecting* it.

rriddle marked 2 inline comments as done.Dec 11 2020, 4:10 PM
rriddle added inline comments.
mlir/docs/PassManagement.md
43

Ah yes, I glanced over the first part. Adding it back.

rriddle updated this revision to Diff 311332.Dec 11 2020, 4:17 PM
rriddle marked an inline comment as done.

Update

mehdi_amini accepted this revision.Dec 11 2020, 5:14 PM
This revision is now accepted and ready to land.Dec 11 2020, 5:14 PM
This revision was landed with ongoing or failed builds.Dec 11 2020, 5:53 PM
This revision was automatically updated to reflect the committed changes.