This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Use TARGET_FILE instead of TARGET_SONAME_FILE when generating ABI lists
ClosedPublic

Authored by ldionne on Dec 8 2020, 9:17 AM.

Details

Summary

TARGET_SONAME_FILE isn't valid on Windows, and TARGET_FILE should achieve
the same results.

Diff Detail

Event Timeline

ldionne created this revision.Dec 8 2020, 9:17 AM
ldionne requested review of this revision.Dec 8 2020, 9:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 8 2020, 9:17 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

This is an attempt to find an alternative fix for D92541.

ldionne updated this revision to Diff 310248.Dec 8 2020, 9:20 AM

Fix typo.

ldionne added a subscriber: lanza.Dec 8 2020, 10:38 AM

@lanza Can you check whether that solves your problem on Windows? We don't have any Windows pre-commit CI.

lanza accepted this revision.Dec 9 2020, 1:57 PM
This comment was removed by lanza.
lanza added a comment.Dec 9 2020, 1:58 PM

Yup, this worked. Thank you, Louis! I can also verify that the test suite passed on centOS, Darwin and Windows with a pretty standard build.

ldionne accepted this revision.Dec 11 2020, 9:12 AM

Yup, this worked. Thank you, Louis! I can also verify that the test suite passed on centOS, Darwin and Windows with a pretty standard build.

Excellent, thanks!

This revision is now accepted and ready to land.Dec 11 2020, 9:12 AM