[libc++] Use TARGET_FILE instead of TARGET_SONAME_FILE when generating ABI lists

[ldionne]

Summary

TARGET_SONAME_FILE isn't valid on Windows, and TARGET_FILE should achieve
the same results.

[ldionne]

This is an attempt to find an alternative fix for D92541.

[ldionne]

Fix typo.

[ldionne]

@lanza Can you check whether that solves your problem on Windows? We don't have any Windows pre-commit CI.

[lanza]

This comment was removed by lanza.

[lanza]

Yup, this worked. Thank you, Louis! I can also verify that the test suite passed on centOS, Darwin and Windows with a pretty standard build.

[ldionne]

In D92856#2443814, @lanza wrote:

Yup, this worked. Thank you, Louis! I can also verify that the test suite passed on centOS, Darwin and Windows with a pretty standard build.

Excellent, thanks!

libcxx/lib/abi/CMakeLists.txt

 if (TARGET cxx_shared)
   set(abi_list_file "${CMAKE_CURRENT_SOURCE_DIR}/${abi_list_identifier}.abilist")
 
   if (EXISTS "${abi_list_file}")
     add_custom_target(check-cxx-abilist
       "${Python3_EXECUTABLE}" "${LIBCXX_SOURCE_DIR}/utils/sym_diff.py"
           --only-stdlib-symbols
           --strict "${abi_list_file}"
-          $<TARGET_SONAME_FILE:cxx_shared>
+          $<TARGET_FILE:cxx_shared>
       DEPENDS cxx_shared
       COMMENT "Testing libc++'s exported symbols against the ABI list")
   else()
     message(STATUS "ABI list file not generated for configuration ${abi_list_identifier}, `check-cxx-abilist` will not be available.")
   endif()
 
   add_custom_target(generate-cxx-abilist
     COMMAND "${Python3_EXECUTABLE}" "${LIBCXX_SOURCE_DIR}/utils/generate_abi_list.py"
             --output "${abi_list_file}"
-            "$<TARGET_SONAME_FILE:cxx_shared>"
+            "$<TARGET_FILE:cxx_shared>"
     DEPENDS cxx_shared
     COMMENT "Generating the ABI list file for configuration ${abi_list_identifier}")
 else()
   message(STATUS "Not building a shared library for libc++ -- the ABI list targets will not be available.")
 endif()