This is an archive of the discontinued LLVM Phabricator instance.

[lldb] [test] Fix continue_to_breakpoint() args in TestThreadStepOut
ClosedPublic

Authored by mgorny on Dec 7 2020, 12:33 AM.

Reviewers

Commits

Summary

The test is skipped/xfailing on all platforms, so it seems that the API
got out of sync. Fix that so it returns to a 'proper' failure
on FreeBSD.

mgorny requested review of this revision.Dec 7 2020, 12:33 AM

This revision is now accepted and ready to land.Dec 7 2020, 12:50 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

lldb/

test/

API/

functionalities/

thread/

step_out/

3 lines

Show First 20 Lines • Show All 139 Lines • ▼ Show 20 Lines	def step_out_test(self, step_out_func):

(breakpoint_threads, other_threads) = ([], [])		(breakpoint_threads, other_threads) = ([], [])
lldbutil.sort_stopped_threads(self.inferior_process,		lldbutil.sort_stopped_threads(self.inferior_process,
breakpoint_threads=breakpoint_threads,		breakpoint_threads=breakpoint_threads,
other_threads=other_threads)		other_threads=other_threads)
if len(breakpoint_threads) == 1:		if len(breakpoint_threads) == 1:
success = thread.Suspend()		success = thread.Suspend()
self.assertTrue(success, "Couldn't suspend a thread")		self.assertTrue(success, "Couldn't suspend a thread")
bkpt_threads = lldbutil.continue_to_breakpoint(bkpt)		bkpt_threads = lldbutil.continue_to_breakpoint(self.inferior_process,
		bkpt)
self.assertEqual(len(bkpt_threads), 1, "Second thread stopped")		self.assertEqual(len(bkpt_threads), 1, "Second thread stopped")
success = thread.Resume()		success = thread.Resume()
self.assertTrue(success, "Couldn't resume a thread")		self.assertTrue(success, "Couldn't resume a thread")

self.step_out_thread = breakpoint_threads[0]		self.step_out_thread = breakpoint_threads[0]

# Step out of thread stopped at breakpoint		# Step out of thread stopped at breakpoint
step_out_func()		step_out_func()