[lldb] [Platform/POSIX] Use gdb-remote plugin when attaching

[mgorny]

Summary

Force gdb-remote plugin when attaching using the derivatives
of PlatformPOSIX class. This is consistent with the behavior
for launching processes (via DebugProcess() method) and guarantees
consistent plugin choice on FreeBSD.

[emaste]

No objection here. I'm curious why the two modified tests work on Linux or NetBSD today though?

[krytarowski]

In D92667#2434223, @emaste wrote:

No objection here. I'm curious why the two modified tests work on Linux or NetBSD today though?

This is a debt of having 2 process plugins. NetBSD and Linux ship with a single one only.

[mgorny]

In D92667#2434223, @emaste wrote:

No objection here. I'm curious why the two modified tests work on Linux or NetBSD today though?

What Kamil said. We're still having two plugins, while these other platforms have only a remote plugin nowadays. Nevertheless, the code here is inconsistent and it's worth fixing, even if it will make no difference long-term.

[emaste]

Ah, of course. SGTM.

[labath]

This is consistent with the way we launch processes, so lgtm.

lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp

if (target && error.Success()) {
         LLDB_LOGF(log, "PlatformPOSIX::%s set selected target to %p %s",
                   __FUNCTION__, (void *)target,
                   exe_module_sp ? exe_module_sp->GetFileSpec().GetPath().c_str()
                                 : "<null>");
       }
 
       process_sp =
           target->CreateProcess(attach_info.GetListenerForProcess(debugger),
-                                attach_info.GetProcessPluginName(), nullptr,
-                                false);
+                                "gdb-remote", nullptr, true);
 
       if (process_sp) {
         ListenerSP listener_sp = attach_info.GetHijackListener();
         if (listener_sp == nullptr) {
           listener_sp =
               Listener::MakeListener("lldb.PlatformPOSIX.attach.hijack");
           attach_info.SetHijackListener(listener_sp);
         }

lldb/test/API/commands/process/attach-resume/TestAttachResume.py

 
 
 class AttachResumeTestCase(TestBase):
 
     mydir = TestBase.compute_mydir(__file__)
     NO_DEBUG_INFO_TESTCASE = True
 
     @skipIfRemote
-    @expectedFailureAll(oslist=['freebsd'], bugnumber='llvm.org/pr19310')
     @expectedFailureNetBSD
     @skipIfWindows # llvm.org/pr24778, llvm.org/pr21753
     @skipIfReproducer # FIXME: Unexpected packet during (active) replay
     def test_attach_continue_interrupt_detach(self):
         """Test attach/continue/interrupt/detach"""
         self.build()
         self.process_attach_continue_interrupt_detach()
 

lldb/test/API/functionalities/deleted-executable/TestDeletedExecutable.py

class TestDeletedExecutable(TestBase):
 
     mydir = TestBase.compute_mydir(__file__)
     NO_DEBUG_INFO_TESTCASE = True
 
     @skipIfWindows # cannot delete a running executable
     @expectedFailureAll(oslist=["linux"],
         triple=no_match('aarch64-.*-android'))
         # determining the architecture of the process fails
-    @expectedFailureAll(oslist=["freebsd"], bugnumber="llvm.org/pr48374")
     @skipIfReproducer # File synchronization is not supported during replay.
     def test(self):
         self.build()
         exe = self.getBuildArtifact("a.out")
 
         # Use a file as a synchronization point between test and inferior.
         pid_file_path = lldbutil.append_to_process_working_directory(self,
             "token_pid_%d" % (int(os.getpid())))