Page MenuHomePhabricator

[IRSimilarity] Don't copy the Mapper for createCandidatesFromSuffixTree
ClosedPublic

Authored by lanza on Dec 2 2020, 6:16 PM.

Details

Summary

Every invocation this was copying the Mapper for no reason. Take a const
ref instead

Diff Detail

Event Timeline

lanza created this revision.Dec 2 2020, 6:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 2 2020, 6:16 PM
lanza requested review of this revision.Dec 2 2020, 6:16 PM
AndrewLitteken added a comment.EditedDec 2 2020, 8:27 PM

Good catch, this looks fine to me, but like the other patch, please wait for one of the other reviewers.

plotfi accepted this revision.Jan 20 2021, 4:42 PM

Is this still open? Seems good to go.

This revision is now accepted and ready to land.Jan 20 2021, 4:42 PM
paquette accepted this revision.Jan 20 2021, 6:02 PM

Yeah this seems fine

Same for this one, can I merge this on behalf of @lanza?

closing since the patch has been landed.