This is an archive of the discontinued LLVM Phabricator instance.

[IRSimilarity] Don't copy the Mapper for createCandidatesFromSuffixTree
ClosedPublic

Authored by lanza on Dec 2 2020, 6:16 PM.

Reviewers

Summary

Every invocation this was copying the Mapper for no reason. Take a const
ref instead

lanza requested review of this revision.Dec 2 2020, 6:16 PM

Good catch, this looks fine to me, but like the other patch, please wait for one of the other reviewers.

Is this still open? Seems good to go.

This revision is now accepted and ready to land.Jan 20 2021, 4:42 PM

Yeah this seems fine

Same for this one, can I merge this on behalf of @lanza?

closing since the patch has been landed.

Path

Size

llvm/

lib/

Analysis/

2 lines

Context not available.
	/// \param [out] CandsForRepSubstring - The vector to store the generated	/// \param [out] CandsForRepSubstring - The vector to store the generated
	/// IRSimilarityCandidates.	/// IRSimilarityCandidates.
	static void createCandidatesFromSuffixTree(	static void createCandidatesFromSuffixTree(
	IRInstructionMapper Mapper, std::vector<IRInstructionData *> &InstrList,	const IRInstructionMapper& Mapper, std::vector<IRInstructionData *> &InstrList,
	std::vector<unsigned> &IntegerMapping, SuffixTree::RepeatedSubstring &RS,	std::vector<unsigned> &IntegerMapping, SuffixTree::RepeatedSubstring &RS,
	std::vector<IRSimilarityCandidate> &CandsForRepSubstring) {	std::vector<IRSimilarityCandidate> &CandsForRepSubstring) {

Context not available.