Page MenuHomePhabricator

[MLIR][NFC] Fix mix up between dialect attribute values and names
ClosedPublic

Authored by bondhugula on Dec 2 2020, 12:45 PM.

Details

Summary

Clear up documentation on dialect attribute values and fix/improve
ModuleOp verifier error message on dialect prefixed attribute names.
Additional discussion is here:
https://llvm.discourse.group/t/moduleop-attributes/2325

Diff Detail

Event Timeline

bondhugula created this revision.Dec 2 2020, 12:45 PM
bondhugula requested review of this revision.Dec 2 2020, 12:45 PM
rriddle accepted this revision.Dec 2 2020, 12:46 PM

LGTM. Thanks for fixing this!

This revision is now accepted and ready to land.Dec 2 2020, 12:46 PM
This revision was landed with ongoing or failed builds.Dec 2 2020, 1:05 PM
This revision was automatically updated to reflect the committed changes.