This is an archive of the discontinued LLVM Phabricator instance.

Differential D92442

[lsan] Use final on Fuchsia ThreadContext declaration
ClosedPublic

Authored by mcgrathr on Dec 1 2020, 6:29 PM.

Details

Reviewers
leonardchan
eugenis
vitalybuka
Commits
rG827e075676f6: [lsan] Use final on Fuchsia ThreadContext declaration
Summary

This is consistent with other platforms' versions and
eliminates a compiler warning.

Diff Detail

Event Timeline

mcgrathr created this revision.Dec 1 2020, 6:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 1 2020, 6:29 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
mcgrathr requested review of this revision.Dec 1 2020, 6:29 PM
leonardchan accepted this revision.Dec 1 2020, 6:40 PM
This revision is now accepted and ready to land.Dec 1 2020, 6:40 PM
Harbormaster completed remote builds in B80748: Diff 308834.Dec 1 2020, 6:58 PM
This revision was landed with ongoing or failed builds.Dec 2 2020, 11:58 AM
Closed by commit rG827e075676f6: [lsan] Use final on Fuchsia ThreadContext declaration (authored by mcgrathr). · Explain Why
This revision was automatically updated to reflect the committed changes.
mcgrathr added a commit: rG827e075676f6: [lsan] Use final on Fuchsia ThreadContext declaration.

Revision Contents

PathSize
compiler-rt/
lib/
lsan/
2 lines

Diff 308834

compiler-rt/lib/lsan/lsan_fuchsia.h

Show All 12 Lines
#ifndef LSAN_FUCHSIA_H #ifndef LSAN_FUCHSIA_H
#define LSAN_FUCHSIA_H #define LSAN_FUCHSIA_H
#include "lsan_thread.h" #include "lsan_thread.h"
#include "sanitizer_common/sanitizer_platform.h" #include "sanitizer_common/sanitizer_platform.h"
#if !SANITIZER_FUCHSIA #if !SANITIZER_FUCHSIA
#error "lsan_fuchsia.h is used only on Fuchsia systems (SANITIZER_FUCHSIA)" #error "lsan_fuchsia.h is used only on Fuchsia systems (SANITIZER_FUCHSIA)"
Lint: Pre-merge checks
Inline Actions

clang-tidy: error: "lsan_fuchsia.h is used only on Fuchsia systems (SANITIZER_FUCHSIA)" [clang-diagnostic-error]
not useful

Lint: Pre-merge checks: clang-tidy: error: "lsan_fuchsia.h is used only on Fuchsia systems (SANITIZER_FUCHSIA)" [clang…
#endif #endif
namespace __lsan { namespace __lsan {
class ThreadContext : public ThreadContextLsanBase { class ThreadContext final : public ThreadContextLsanBase {
public: public:
explicit ThreadContext(int tid); explicit ThreadContext(int tid);
void OnCreated(void *arg) override; void OnCreated(void *arg) override;
void OnStarted(void *arg) override; void OnStarted(void *arg) override;
}; };
} // namespace __lsan } // namespace __lsan
#endif // LSAN_FUCHSIA_H #endif // LSAN_FUCHSIA_H