This is an archive of the discontinued LLVM Phabricator instance.

[msan] Replace 8 by kShadowTLSAlignment
ClosedPublic

Authored by stephan.yichao.zhao on Nov 28 2020, 9:05 PM.

Reviewers

eugenis

Commits

rG405ea2b93d96: [msan] Replace 8 by kShadowTLSAlignment

	Time	Test
	400 ms	x64 debian > HWAddressSanitizer-x86_64.TestCases::sizes.cpp
	40 ms	x64 windows > Clangd Unit Tests._/ClangdTests_exe::ConfigCompileTests.ExternalBlockDisablesBackgroundIndex
	40 ms	x64 windows > Clangd Unit Tests._/ClangdTests_exe::ConfigCompileTests.ExternalBlockMountPoint

LGTM

This revision is now accepted and ready to land.Nov 30 2020, 1:38 PM

This revision was landed with ongoing or failed builds.Dec 1 2020, 5:11 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

lib/

Transforms/

Instrumentation/

2 lines

Show First 20 Lines • Show All 3,698 Lines • ▼ Show 20 Lines	for (auto ArgIt = CB.arg_begin(), End = CB.arg_end(); ArgIt != End;
if (Cst && Cst->isNullValue()) ArgIsInitialized = true;		if (Cst && Cst->isNullValue()) ArgIsInitialized = true;
}		}
if (MS.TrackOrigins && !ArgIsInitialized)		if (MS.TrackOrigins && !ArgIsInitialized)
IRB.CreateStore(getOrigin(A),		IRB.CreateStore(getOrigin(A),
getOriginPtrForArgument(A, IRB, ArgOffset));		getOriginPtrForArgument(A, IRB, ArgOffset));
(void)Store;		(void)Store;
assert(Size != 0 && Store != nullptr);		assert(Size != 0 && Store != nullptr);
LLVM_DEBUG(dbgs() << " Param:" << *Store << "\n");		LLVM_DEBUG(dbgs() << " Param:" << *Store << "\n");
ArgOffset += alignTo(Size, 8);		ArgOffset += alignTo(Size, kShadowTLSAlignment);
}		}
LLVM_DEBUG(dbgs() << " done with call args\n");		LLVM_DEBUG(dbgs() << " done with call args\n");

FunctionType *FT = CB.getFunctionType();		FunctionType *FT = CB.getFunctionType();
if (FT->isVarArg()) {		if (FT->isVarArg()) {
VAHelper->visitCallBase(CB, IRB);		VAHelper->visitCallBase(CB, IRB);
}		}

▲ Show 20 Lines • Show All 1,603 Lines • Show Last 20 Lines