Page MenuHomePhabricator
Differential D92225

[AIX][XCOFF][NFC] Change geNumberOfVRSaved function name to getNumberOfVRSaved.
ClosedPublic
Actions

Authored by DiggerLin on Nov 27 2020, 6:09 AM.

Details

Reviewers
jasonliu
hubert.reinterpretcast
Commits
rG851779652a3b: [AIX][XCOFF][NFC] Change geNumberOfVRSaved function name to getNumberOfVRSaved.

Diff Detail

Event Timeline

DiggerLin created this revision.Nov 27 2020, 6:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 27 2020, 6:09 AM
Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript
DiggerLin requested review of this revision.Nov 27 2020, 6:09 AM
Harbormaster completed remote builds in B80340: Diff 308034.Nov 27 2020, 6:57 AM
jasonliu added inline comments.Nov 27 2020, 7:10 AM
llvm/unittests/Object/XCOFFObjectFileTest.cpp
235

Please fix clang-tidy error.

DiggerLin retitled this revision from [AIX][XCOFF][NFC] Change geNumberOfVRSaved entry to getNumberOfVRSaved. to [AIX][XCOFF][NFC] Change geNumberOfVRSaved function name to getNumberOfVRSaved..Nov 27 2020, 7:29 AM
DiggerLin updated this revision to Diff 308054.Nov 27 2020, 7:38 AM

address comment

hubert.reinterpretcast accepted this revision.Nov 27 2020, 7:44 AM
hubert.reinterpretcast added a subscriber: hubert.reinterpretcast.

LGTM.

This revision is now accepted and ready to land.Nov 27 2020, 7:44 AM
DiggerLin mentioned this in D89049: [AIX][XCOFF] print out the traceback info .Nov 27 2020, 7:45 AM
Harbormaster completed remote builds in B80348: Diff 308054.Nov 27 2020, 8:16 AM
Closed by commit rG851779652a3b: [AIX][XCOFF][NFC] Change geNumberOfVRSaved function name to getNumberOfVRSaved. (authored by DiggerLin). · Explain WhyNov 27 2020, 10:39 AM
This revision was automatically updated to reflect the committed changes.
DiggerLin added a commit: rG851779652a3b: [AIX][XCOFF][NFC] Change geNumberOfVRSaved function name to getNumberOfVRSaved..

Revision Contents
Changeset List

PathSize
llvm/
include/
llvm/
Object/
2 lines
lib/
Object/
2 lines
unittests/
Object/
4 lines

Diff 308088

View Options

llvm/include/llvm/Object/XCOFFObjectFile.h

Loading...
View Options

llvm/lib/Object/XCOFFObjectFile.cpp

Loading...
View Options

llvm/unittests/Object/XCOFFObjectFileTest.cpp

Loading...