This is an archive of the discontinued LLVM Phabricator instance.

Differential D92182

[mlir] Let ModuleTranslate propagate LLVM triple
ClosedPublic

Authored by nicolasvasilache on Nov 26 2020, 7:58 AM.

Details

Reviewers
ftynse
Commits
rG5dd5a083630c: [mlir] Let ModuleTranslate propagate LLVM triple
Summary

This adds LLVM triple propagation and updates the test that did not check it properly.

Diff Detail

Event Timeline

nicolasvasilache created this revision.Nov 26 2020, 7:58 AM
Herald added a reviewer: ftynse. · View Herald TranscriptNov 26 2020, 7:58 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: teijeong, rdzhabarov, tatianashp and 14 others. · View Herald Transcript
nicolasvasilache requested review of this revision.Nov 26 2020, 7:58 AM
Herald added a subscriber: stephenneuendorffer. · View Herald TranscriptNov 26 2020, 7:58 AM
nicolasvasilache updated this revision to Diff 307873.Nov 26 2020, 8:09 AM

Don't break another test :p

Harbormaster completed remote builds in B80241: Diff 307872.Nov 26 2020, 8:15 AM
Harbormaster completed remote builds in B80243: Diff 307873.Nov 26 2020, 8:26 AM
ftynse accepted this revision.Nov 26 2020, 8:32 AM
This revision is now accepted and ready to land.Nov 26 2020, 8:32 AM
Closed by commit rG5dd5a083630c: [mlir] Let ModuleTranslate propagate LLVM triple (authored by nicolasvasilache). · Explain WhyNov 27 2020, 12:05 AM
This revision was automatically updated to reflect the committed changes.
nicolasvasilache added a commit: rG5dd5a083630c: [mlir] Let ModuleTranslate propagate LLVM triple.

Revision Contents

PathSize
mlir/
lib/
Target/
LLVMIR/
3 lines
test/
Target/
1 line

Diff 307873

mlir/lib/Target/LLVMIR/ModuleTranslation.cpp

Show First 20 Lines • Show All 940 Lines • ▼ Show 20 Lines
std::unique_ptr<llvm::Module> ModuleTranslation::prepareLLVMModule( std::unique_ptr<llvm::Module> ModuleTranslation::prepareLLVMModule(
Operation *m, llvm::LLVMContext &llvmContext, StringRef name) { Operation *m, llvm::LLVMContext &llvmContext, StringRef name) {
m->getContext()->getOrLoadDialect<LLVM::LLVMDialect>(); m->getContext()->getOrLoadDialect<LLVM::LLVMDialect>();
auto llvmModule = std::make_unique<llvm::Module>(name, llvmContext); auto llvmModule = std::make_unique<llvm::Module>(name, llvmContext);
if (auto dataLayoutAttr = if (auto dataLayoutAttr =
m->getAttr(LLVM::LLVMDialect::getDataLayoutAttrName())) m->getAttr(LLVM::LLVMDialect::getDataLayoutAttrName()))
llvmModule->setDataLayout(dataLayoutAttr.cast<StringAttr>().getValue()); llvmModule->setDataLayout(dataLayoutAttr.cast<StringAttr>().getValue());
if (auto targetTripleAttr =
m->getAttr(LLVM::LLVMDialect::getTargetTripleAttrName()))
llvmModule->setTargetTriple(targetTripleAttr.cast<StringAttr>().getValue());
// Inject declarations for `malloc` and `free` functions that can be used in // Inject declarations for `malloc` and `free` functions that can be used in
// memref allocation/deallocation coming from standard ops lowering. // memref allocation/deallocation coming from standard ops lowering.
llvm::IRBuilder<> builder(llvmContext); llvm::IRBuilder<> builder(llvmContext);
llvmModule->getOrInsertFunction("malloc", builder.getInt8PtrTy(), llvmModule->getOrInsertFunction("malloc", builder.getInt8PtrTy(),
builder.getInt64Ty()); builder.getInt64Ty());
llvmModule->getOrInsertFunction("free", builder.getVoidTy(), llvmModule->getOrInsertFunction("free", builder.getVoidTy(),
builder.getInt8PtrTy()); builder.getInt8PtrTy());
return llvmModule; return llvmModule;
} }

mlir/test/Target/llvmir.mlir

Show First 20 Lines • Show All 1,313 Lines • ▼ Show 20 Lines
// ----- // -----
// CHECK: "CodeView", i32 1 // CHECK: "CodeView", i32 1
module attributes {llvm.target_triple = "x86_64-pc-windows-msvc"} {} module attributes {llvm.target_triple = "x86_64-pc-windows-msvc"} {}
// ----- // -----
// CHECK-NOT: "CodeView", i32 1 // CHECK-NOT: "CodeView", i32 1
// CHECK: aarch64-linux-android
module attributes {llvm.target_triple = "aarch64-linux-android"} {} module attributes {llvm.target_triple = "aarch64-linux-android"} {}
// ----- // -----
// CHECK-NOT: "CodeView", i32 1 // CHECK-NOT: "CodeView", i32 1
module attributes {} {} module attributes {} {}