Page MenuHomePhabricator

[LangRef] Add poison constant
ClosedPublic

Authored by aqjune on Nov 26 2020, 2:37 AM.

Details

Summary

This patch adds a description about the newly added poison constant to LangRef.

Diff Detail

Event Timeline

aqjune created this revision.Nov 26 2020, 2:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 26 2020, 2:37 AM
aqjune requested review of this revision.Nov 26 2020, 2:37 AM
fhahn added a subscriber: fhahn.Nov 26 2020, 4:04 AM
nikic accepted this revision.Nov 26 2020, 11:34 AM

LGTM

llvm/docs/LangRef.rst
3660

Would personally drop this sentence, seems pretty vague.

3735

%poison2 is already used below.

This revision is now accepted and ready to land.Nov 26 2020, 11:34 AM
This revision was landed with ongoing or failed builds.Nov 26 2020, 5:30 PM
This revision was automatically updated to reflect the committed changes.
aqjune marked an inline comment as done.Nov 26 2020, 5:31 PM
aqjune added inline comments.Nov 27 2020, 11:45 PM
llvm/docs/LangRef.rst
3660

(it was saved as a draft, submitting now) A high-level definition of poison was necessary IMO - so I put a topic sentence here. Since technical descriptions are below, I think it is okay to be conceptual here.