Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

People liuz

liuz (Zhengyang Liu)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 20 2017, 9:18 PM (323 w, 6 d)

Recent Activity
View All

Jul 28 2023

liuz added a comment to D147373: [InstCombine] fold double reverses.

ping

Jul 28 2023, 9:37 PM · Restricted Project, Restricted Project
liuz updated the diff for D147373: [InstCombine] fold double reverses.

rebased

Jul 28 2023, 9:37 PM · Restricted Project, Restricted Project

May 17 2023

liuz added a comment to D147373: [InstCombine] fold double reverses.

hey @craig.topper thanks for the comments. I've updated my patch, please kindly have a look again if you have time :) thanks.

May 17 2023, 4:15 PM · Restricted Project, Restricted Project
liuz updated the diff for D147373: [InstCombine] fold double reverses.

rebase + solve comments

May 17 2023, 4:12 PM · Restricted Project, Restricted Project

Apr 5 2023

liuz added a comment to D147373: [InstCombine] fold double reverses.

ping

Apr 5 2023, 11:46 AM · Restricted Project, Restricted Project

Apr 1 2023

liuz added inline comments to D147373: [InstCombine] fold double reverses.
Apr 1 2023, 7:06 PM · Restricted Project, Restricted Project
liuz updated the diff for D147373: [InstCombine] fold double reverses.
Apr 1 2023, 5:24 PM · Restricted Project, Restricted Project
liuz updated the diff for D147373: [InstCombine] fold double reverses.

fixed the failing test case.

Apr 1 2023, 4:18 PM · Restricted Project, Restricted Project
liuz added a comment to D147373: [InstCombine] fold double reverses.

All the new test cases are validated by Alive2.

Apr 1 2023, 11:43 AM · Restricted Project, Restricted Project
liuz added a comment to D147373: [InstCombine] fold double reverses.
In D147373#4238398, @RKSimon wrote:

Why is the test file called reverse-loop.ll when it doesn't involve loops?

Apr 1 2023, 11:42 AM · Restricted Project, Restricted Project
liuz added inline comments to D147373: [InstCombine] fold double reverses.
Apr 1 2023, 11:39 AM · Restricted Project, Restricted Project
liuz added a comment to D147373: [InstCombine] fold double reverses.
In D147373#4238404, @nikic wrote:

As this is not a cost-model driven transform, it should be part of InstCombine, not VectorCombine.

Apr 1 2023, 11:32 AM · Restricted Project, Restricted Project
liuz updated the diff for D147373: [InstCombine] fold double reverses.

Updated the patch according to comments

Apr 1 2023, 11:30 AM · Restricted Project, Restricted Project
liuz updated the diff for D147373: [InstCombine] fold double reverses.
Apr 1 2023, 3:42 AM · Restricted Project, Restricted Project
liuz updated the diff for D147373: [InstCombine] fold double reverses.
Apr 1 2023, 3:39 AM · Restricted Project, Restricted Project
liuz updated the summary of D147373: [InstCombine] fold double reverses.
Apr 1 2023, 3:24 AM · Restricted Project, Restricted Project
liuz requested review of D147373: [InstCombine] fold double reverses.
Apr 1 2023, 3:17 AM · Restricted Project, Restricted Project

Nov 26 2020

liuz committed rG345fcccb3379: Fix use-of-uninitialized-value in rG75f50e15bf8f (authored by liuz).
Fix use-of-uninitialized-value in rG75f50e15bf8f
Nov 26 2020, 12:40 AM

Nov 25 2020

liuz committed rG75f50e15bf8f: Adding PoisonValue for representing poison value explicitly in IR (authored by liuz).
Adding PoisonValue for representing poison value explicitly in IR
Nov 25 2020, 4:44 PM
liuz closed D71126: Adding PoisonValue for representing poison value explicitly in IR.
Nov 25 2020, 4:44 PM · Restricted Project

Nov 24 2020

liuz updated the diff for D71126: Adding PoisonValue for representing poison value explicitly in IR.

rebased to upstream

Nov 24 2020, 2:00 PM · Restricted Project

Oct 8 2020

liuz updated the summary of D71126: Adding PoisonValue for representing poison value explicitly in IR.
Oct 8 2020, 11:00 PM · Restricted Project
liuz updated the diff for D71126: Adding PoisonValue for representing poison value explicitly in IR.

PoisonValue is now a subclass of UndefValue

Oct 8 2020, 10:59 PM · Restricted Project

Oct 6 2020

liuz retitled D71126: Adding PoisonValue for representing poison value explicitly in IR from Add Poison Value to Adding PoisonValue for representing poison value explicitly in IR.
Oct 6 2020, 5:32 PM · Restricted Project
liuz updated the diff for D71126: Adding PoisonValue for representing poison value explicitly in IR.
Oct 6 2020, 5:21 PM · Restricted Project

Dec 6 2019

liuz updated the summary of D71126: Adding PoisonValue for representing poison value explicitly in IR.
Dec 6 2019, 9:18 AM · Restricted Project
Herald added a reviewer for D71126: Adding PoisonValue for representing poison value explicitly in IR: whitequark.
Dec 6 2019, 8:57 AM · Restricted Project

Nov 17 2019

liuz added a comment to D70246: [InstCombine] remove identity shuffle simplification for mask with undefs.

Converting poison to undef is okay, but undef to poison is not. undef & 0 == undef, but poison & 0 == poison. If undef can be optimized to poison, this can cause miscompilation. See here: https://rise4fun.com/Alive/DFYf , https://rise4fun.com/Alive/OZU

Nov 17 2019, 11:09 PM · Restricted Project