Page MenuHomePhabricator

[TableGen][SchedModels] Get rid of hasVariant. NFC
ClosedPublic

Authored by evgeny777 on Nov 24 2020, 6:29 AM.

Details

Summary

substituteVariantOperand already has the checking logic, so we don't really need this function. Subtarget files are unchanged by the patch.

Diff Detail

Event Timeline

evgeny777 created this revision.Nov 24 2020, 6:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 24 2020, 6:29 AM
evgeny777 requested review of this revision.Nov 24 2020, 6:29 AM

I've only skimmed through the code, but it looks like a nice improvement.

When you say that " Subtarget files are unchanged by the patch", does it mean that you have checked all the targets or just ARM?

When you say that " Subtarget files are unchanged by the patch", does it mean that you have checked all the targets or just ARM?

I checked ARM, AArch64 and X86. Does any other have scheduling enabled?

When you say that " Subtarget files are unchanged by the patch", does it mean that you have checked all the targets or just ARM?

I checked ARM, AArch64 and X86. Does any other have scheduling enabled?

I don't know to be honest.
A quick grep shows that Target/AMDGPU/SISchedule.td has a SchedReadVariant and a SchedWriteVariant.

foad added a subscriber: foad.Nov 24 2020, 9:24 AM

@andreadb Built all targets, looks like none is touched (checked RISCV, AMDGPU, PPC, Lanai, etc)

andreadb accepted this revision.Nov 25 2020, 2:57 AM

Thanks for checking.

LGTM

This revision is now accepted and ready to land.Nov 25 2020, 2:57 AM
This revision was automatically updated to reflect the committed changes.