Page MenuHomePhabricator

[lld/mac] Implement basic typo correction for flags
ClosedPublic

Authored by thakis on Nov 23 2020, 7:53 AM.

Details

Summary

Also use "unknown flag 'flag'" instead of "unknown flag: flag" for
consistency with the other ports.

Diff Detail

Event Timeline

thakis requested review of this revision.Nov 23 2020, 7:53 AM
thakis created this revision.
hans accepted this revision.Nov 24 2020, 8:29 AM
hans added a subscriber: hans.
hans added inline comments.
lld/MachO/DriverUtils.cpp
78–85

i probably would have kept opt::Arg here, but i guess it's a personal preference

lld/test/MachO/driver.test
2

nit: blank line after run line is common (or am i just imagining this?)

This revision is now accepted and ready to land.Nov 24 2020, 8:29 AM
thakis marked 2 inline comments as done.Nov 24 2020, 8:33 AM

Thanks! Landing.

This revision was automatically updated to reflect the committed changes.
Herald added a reviewer: MaskRay. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript