This is an archive of the discontinued LLVM Phabricator instance.

Differential D91953

[llvm-readobj][test] - Simplify the gnu-notes.test
ClosedPublic

Authored by grimar on Nov 23 2020, 3:12 AM.

Details

Reviewers
jhenderson
MaskRay
• espindola
Commits
rG2745d9c586d1: [llvm-readobj][test] - Simplify the gnu-notes.test
Summary

This test contains YAMLs that can be merged with use of macros.
This opens road for adding more test cases.

Diff Detail

Event Timeline

grimar created this revision.Nov 23 2020, 3:12 AM
Herald added a reviewer: • espindola. · View Herald TranscriptNov 23 2020, 3:12 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: rupprecht, emaste. · View Herald Transcript
grimar requested review of this revision.Nov 23 2020, 3:12 AM
jhenderson accepted this revision.Nov 23 2020, 4:31 AM

Makes sense, LGTM.

This revision is now accepted and ready to land.Nov 23 2020, 4:31 AM
Closed by commit rG2745d9c586d1: [llvm-readobj][test] - Simplify the gnu-notes.test (authored by grimar). · Explain WhyNov 23 2020, 5:26 AM
This revision was automatically updated to reflect the committed changes.
grimar added a commit: rG2745d9c586d1: [llvm-readobj][test] - Simplify the gnu-notes.test.

Revision Contents

PathSize
llvm/
test/
tools/
llvm-readobj/
ELF/
44 lines

Diff 307053

llvm/test/tools/llvm-readobj/ELF/gnu-notes.test

Show First 20 Lines • Show All 106 Lines • ▼ Show 20 LinesProgramHeaders:
- Type: PT_NOTE - Type: PT_NOTE
FileSize: 0x20 FileSize: 0x20
FirstSec: .note.gnu.build-id FirstSec: .note.gnu.build-id
LastSec: .note.gnu.build-id LastSec: .note.gnu.build-id
## Test tools report an error if a note section has an invalid offset ## Test tools report an error if a note section has an invalid offset
## that goes past the end of file. ## that goes past the end of file.
# RUN: yaml2obj --docnum=2 %s -o %t2.so # RUN: yaml2obj --docnum=2 -DSHOFFSET=0xffff0000 %s -o %t2.so
# RUN: not llvm-readelf --notes %t2.so 2>&1 | FileCheck -DFILE=%t2.so %s --check-prefix=ERR1 # RUN: not llvm-readelf --notes %t2.so 2>&1 | FileCheck -DFILE=%t2.so %s --check-prefix=ERR1
# RUN: not llvm-readobj --notes %t2.so 2>&1 | FileCheck -DFILE=%t2.so %s --check-prefix=ERR1 # RUN: not llvm-readobj --notes %t2.so 2>&1 | FileCheck -DFILE=%t2.so %s --check-prefix=ERR1
# ERR1: error: '[[FILE]]': SHT_NOTE section [index 1] has invalid offset (0xffff0000) or size (0x0) # ERR1: error: '[[FILE]]': SHT_NOTE section [index 1] has invalid offset (0xffff0000) or size (0x0)
--- !ELF --- !ELF
FileHeader: FileHeader:
Class: ELFCLASS64 Class: ELFCLASS64
Data: ELFDATA2LSB Data: ELFDATA2LSB
Type: ET_EXEC Type: ET_EXEC
Sections: Sections:
- Name: .note - Name: .note
Type: SHT_NOTE Type: SHT_NOTE
Notes: [] Notes: []
ShOffset: 0xffff0000 ShOffset: [[SHOFFSET=<none>]]
ShSize: [[SHSIZE=<none>]]
## Test tools report an error if a note section has invalid size ## Test tools report an error if a note section has invalid size
## that goes past the end of file. ## that goes past the end of file.
# RUN: yaml2obj --docnum=3 %s -o %t3.so # RUN: yaml2obj --docnum=2 -DSHSIZE=0xffff0000 %s -o %t3.so
# RUN: not llvm-readelf --notes %t3.so 2>&1 | FileCheck -DFILE=%t3.so %s --check-prefix=ERR2 # RUN: not llvm-readelf --notes %t3.so 2>&1 | FileCheck -DFILE=%t3.so %s --check-prefix=ERR2
# RUN: not llvm-readobj --notes %t3.so 2>&1 | FileCheck -DFILE=%t3.so %s --check-prefix=ERR2 # RUN: not llvm-readobj --notes %t3.so 2>&1 | FileCheck -DFILE=%t3.so %s --check-prefix=ERR2
# ERR2: error: '[[FILE]]': SHT_NOTE section [index 1] has invalid offset (0x40) or size (0xffff0000) # ERR2: error: '[[FILE]]': SHT_NOTE section [index 1] has invalid offset (0x40) or size (0xffff0000)
--- !ELF
FileHeader:
Class: ELFCLASS64
Data: ELFDATA2LSB
Type: ET_EXEC
Sections:
- Name: .note
Type: SHT_NOTE
ShSize: 0xffff0000
Notes: []
## Test tools report an error if a note program header has an invalid offset that ## Test tools report an error if a note program header has an invalid offset that
## goes past the end of file. ## goes past the end of file.
# RUN: yaml2obj --docnum=4 %s -o %t4.so # RUN: yaml2obj --docnum=3 -DPHOFFSET=0xffff0000 %s -o %t4.so
# RUN: not llvm-readelf --notes %t4.so 2>&1 | FileCheck -DFILE=%t4.so %s --check-prefix=ERR3 # RUN: not llvm-readelf --notes %t4.so 2>&1 | FileCheck -DFILE=%t4.so %s --check-prefix=ERR3
# RUN: not llvm-readobj --notes %t4.so 2>&1 | FileCheck -DFILE=%t4.so %s --check-prefix=ERR3 # RUN: not llvm-readobj --notes %t4.so 2>&1 | FileCheck -DFILE=%t4.so %s --check-prefix=ERR3
# ERR3: error: '[[FILE]]': PT_NOTE header has invalid offset (0xffff0000) or size (0x0) # ERR3: error: '[[FILE]]': PT_NOTE header has invalid offset (0xffff0000) or size (0x0)
--- !ELF --- !ELF
FileHeader: FileHeader:
Class: ELFCLASS64 Class: ELFCLASS64
Data: ELFDATA2LSB Data: ELFDATA2LSB
Type: ET_CORE Type: ET_CORE
ProgramHeaders: ProgramHeaders:
- Type: PT_NOTE - Type: PT_NOTE
Offset: 0xffff0000 Offset: [[PHOFFSET=<none>]]
FileSize: [[PHFILESIZE=<none>]]
## Test tools report an error if a note program header has an invalid size that ## Test tools report an error if a note program header has an invalid size that
## goes past the end of file. ## goes past the end of file.
# RUN: yaml2obj --docnum=5 %s -o %t5.so # RUN: yaml2obj --docnum=3 -DPHFILESIZE=0xffff0000 %s -o %t5.so
# RUN: not llvm-readelf --notes %t5.so 2>&1 | FileCheck -DFILE=%t5.so %s --check-prefix=ERR4 # RUN: not llvm-readelf --notes %t5.so 2>&1 | FileCheck -DFILE=%t5.so %s --check-prefix=ERR4
# RUN: not llvm-readobj --notes %t5.so 2>&1 | FileCheck -DFILE=%t5.so %s --check-prefix=ERR4 # RUN: not llvm-readobj --notes %t5.so 2>&1 | FileCheck -DFILE=%t5.so %s --check-prefix=ERR4
# ERR4: error: '[[FILE]]': PT_NOTE header has invalid offset (0x78) or size (0xffff0000) # ERR4: error: '[[FILE]]': PT_NOTE header has invalid offset (0x0) or size (0xffff0000)
--- !ELF
FileHeader:
Class: ELFCLASS64
Data: ELFDATA2LSB
Type: ET_CORE
Sections:
- Name: .note
Type: SHT_NOTE
Notes: []
ProgramHeaders:
- Type: PT_NOTE
FileSize: 0xffff0000
FirstSec: .note
LastSec: .note
## Check we report a warning when we are unable to locate the PT_NOTE ## Check we report a warning when we are unable to locate the PT_NOTE
## segment because of broken program headers. ## segment because of broken program headers.
# RUN: yaml2obj --docnum=1 -DPHENTSIZE=1 -DSHNUM=0 %s -o %t6.so # RUN: yaml2obj --docnum=1 -DPHENTSIZE=1 -DSHNUM=0 %s -o %t6.so
# RUN: llvm-readelf --notes %t6.so 2>&1 | FileCheck %s -DFILE=%t6.so --check-prefix=PHENTSIZE-WARN-GNU # RUN: llvm-readelf --notes %t6.so 2>&1 | FileCheck %s -DFILE=%t6.so --check-prefix=PHENTSIZE-WARN-GNU
# RUN: llvm-readobj --notes %t6.so 2>&1 | FileCheck %s -DFILE=%t6.so --check-prefix=PHENTSIZE-WARN-LLVM # RUN: llvm-readobj --notes %t6.so 2>&1 | FileCheck %s -DFILE=%t6.so --check-prefix=PHENTSIZE-WARN-LLVM
# PHENTSIZE-WARN-GNU: warning: '[[FILE]]': unable to read program headers to locate the PT_DYNAMIC segment: invalid e_phentsize: 1 # PHENTSIZE-WARN-GNU: warning: '[[FILE]]': unable to read program headers to locate the PT_DYNAMIC segment: invalid e_phentsize: 1
# PHENTSIZE-WARN-GNU: warning: '[[FILE]]': unable to read program headers to locate the PT_NOTE segment: invalid e_phentsize: 1 # PHENTSIZE-WARN-GNU: warning: '[[FILE]]': unable to read program headers to locate the PT_NOTE segment: invalid e_phentsize: 1
# PHENTSIZE-WARN-LLVM: Notes [ # PHENTSIZE-WARN-LLVM: Notes [
# PHENTSIZE-WARN-LLVM-NEXT: warning: '[[FILE]]': unable to read program headers to locate the PT_NOTE segment: invalid e_phentsize: 1 # PHENTSIZE-WARN-LLVM-NEXT: warning: '[[FILE]]': unable to read program headers to locate the PT_NOTE segment: invalid e_phentsize: 1
# PHENTSIZE-WARN-LLVM-NEXT: ] # PHENTSIZE-WARN-LLVM-NEXT: ]